Skip to content
This repository has been archived by the owner on Jun 7, 2021. It is now read-only.

[TRAFODION-2953] Do not merge #1540

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

moscowgentalman
Copy link
Contributor

@moscowgentalman moscowgentalman commented Apr 25, 2018

This is the very first code drop for TRAFODION-2953, the major purpose is to get feedback to see if the design is OK and shall we continue with this effort or not.
Please check https://issues.apache.org/jira/browse/TRAFODION-2953, I attached a design document there.

This PR contains initial prototype of the design. It still has a major code-refactor to do, but I would like to hear from community first, before I spend more time on it, in case there are something fundamentally wrong.

The major code-refactor I mentioned above is for this prototype code is to add a new PartitionFunction, instead of modifying the SinglePartitionPartitioningFunction directly. I will inherit a new SinglePartitionWithSmallTablePartitioningFunction from SinglePartitionPartitioningFunction next.

One can check the TEST035 to get a demo of how it works.

There are many other tasks following this initial code drop. For example, index/alter/create-super-table etc.

The major idea to support this is to add a new SYSTEM column TBLNM, so in a single Region, rows belong to different tables can be distinguished. When doing IUDS, always add predicate TBLNM = 'theNameOfTheTable' to filter out the correct rows.

Please help to review and let me know your comments, many thanks.

The requirement is strong. In some use cases, there must be many small tables.

@moscowgentalman moscowgentalman changed the title [TRAFODION-2953] initial implementation [TRAFODION-2953] initial implementation of small table in one Hbase Region Apr 25, 2018
@moscowgentalman
Copy link
Contributor Author

something wrong with my PR, most changes not in the PR. Close it.

@moscowgentalman
Copy link
Contributor Author

moscowgentalman commented Apr 25, 2018

Recovered, PR is now OK...
@anoopsharma00 @DaveBirdsall @zellerh , please help to take a review

@Traf-Jenkins
Copy link

Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/2594/

@@ -22,7 +22,7 @@
-- defs included during seabase regr run

#ifdef SEABASE_REGRESS
cqd mode_seabase 'ON';
--cqd mode_seabase 'ON';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo, will fix this in next commit. Sorry

@Traf-Jenkins
Copy link

@moscowgentalman
Copy link
Contributor Author

This PR is not ready, far from ready, sorry, let me close it.

@moscowgentalman
Copy link
Contributor Author

reopen just for some tests, Do not merge

@moscowgentalman moscowgentalman changed the title [TRAFODION-2953] initial implementation of small table in one Hbase Region [TRAFODION-2953] Do not merge Apr 25, 2018
@Traf-Jenkins
Copy link

New Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/2597/

@Traf-Jenkins
Copy link

@Traf-Jenkins
Copy link

Previous Test Aborted. New Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/2598/

@Traf-Jenkins
Copy link

@moscowgentalman
Copy link
Contributor Author

jenkins, retest

@Traf-Jenkins
Copy link

Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/2622/

@Traf-Jenkins
Copy link

@Traf-Jenkins
Copy link

New Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/2624/

@Traf-Jenkins
Copy link

@Traf-Jenkins
Copy link

New Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/2632/

@Traf-Jenkins
Copy link

@Traf-Jenkins
Copy link

Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/2885/

@Traf-Jenkins
Copy link

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants