chore: replace imp built-in module usage for future Python3.12 usage
#31622
Conversation
`imp` module is deprecated in Python 3.4 and removed in Python3.12. This replacement will help with extending Superset support for Python3.12 in the future Signed-off-by: hainenber <[email protected]>
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
I've completed my review and didn't find any issues... but I did find this dog.
/ \__
( @\___
/ O
/ (_____/
/_____/ UNeed a new review? Comment
/korbit-reviewon this PR and I'll review your latest changes.Korbit Guide: Usage and Customization
Interacting with Korbit
- You can manually ask Korbit to review your PR using the
/korbit-reviewcommand in a comment at the root of your PR.- You can ask Korbit to generate a new PR description using the
/korbit-generate-pr-descriptioncommand in any comment on your PR.- Too many Korbit comments? I can resolve all my comment threads if you use the
/korbit-resolvecommand in any comment on your PR.- Chat with Korbit on issues we post by tagging @korbit-ai in your reply.
- Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.
Customizing Korbit
- Check out our docs on how you can make Korbit work best for you and your team.
- Customize Korbit for your organization through the Korbit Console.
Current Korbit Configuration
General Settings
Setting Value Review Schedule Automatic excluding drafts Max Issue Count 10 Automatic PR Descriptions ❌ Issue Categories
Category Enabled Naming ✅ Database Operations ✅ Documentation ✅ Logging ✅ Error Handling ✅ Systems and Environment ✅ Objects and Data Structures ✅ Readability and Maintainability ✅ Asynchronous Processing ✅ Design Patterns ✅ Third-Party Libraries ✅ Performance ✅ Security ✅ Functionality ✅ Feedback and Support
Note
Korbit Pro is free for open source projects 🎉
Looking to add Korbit to your team? Get started with a free 2 week trial here
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #31622 +/- ##
===========================================
+ Coverage 60.48% 83.75% +23.26%
===========================================
Files 1931 538 -1393
Lines 76236 39128 -37108
Branches 8568 0 -8568
===========================================
- Hits 46114 32772 -13342
+ Misses 28017 6356 -21661
+ Partials 2105 0 -2105
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Yikes, failing CI due to wrong Docker credentials |
|
I think @mistercrunch is looking into the docker issue, but it should be non-blocking for the PR, I believe. I think this looks OK to me otherwise, so I'll stamp it and let someone else merge it if they concur :D |
Co-authored-by: Ville Brofeldt <[email protected]>
|
@hainenber sorry about the back and forth, but reading the docs for find_spec, and I don't believe it raises |
|
tackled here too -> https://github.com/apache/superset/pull/31503/files#diff-a4864fcda8cd8d9940c0ef2ae0057381ac247670676c4fd8822c6dc80af333baR21 Since the breaking change window is open, I think we should just merge that PR ^ |
chore(test/integration): replace
impbuilt-in module usage for future Python3.12 usageSUMMARY
impmodule is deprecated in Python 3.4 and removed in Python3.12. This replacement will help with extending Superset support for Python3.12 in the futureBEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TESTING INSTRUCTIONS
This should pass CI checks
ADDITIONAL INFORMATION