WW-5385 Decompose StrutsVelocityContext for better re-usability #839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kusalk
force-pushed
the
WW-5385-strutsvelocitycontext
branch
3 times, most recently
from
9bc7978 to
3916085
Compare
|
SonarCloud note: There are indeed 6 levels of inheritance here but 3 of them are within the Velocity library - plus each of our context classes have a distinct purpose/use, so acceptable IMO |
kusalk
force-pushed
the
WW-5385-strutsvelocitycontext
branch
from
3916085 to
3ac5c06
Compare
|
Closing this for now and considering for Struts 7.0 instead as these changes break backwards compatibility with Velocity 1.x |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WW-5385
Decomposes
StrutsVelocityContextinto:CompositeContext- combines multiple contexts into 1, can only be used as an inner or "chained" contextChainedVelocityContext- extends the standardVelocityContextto correct#getKeyswhen an inner context is usedDirectiveVelocityContext- is additionally capable of rendering Struts directivesStrutsVelocityContext- is additionally capable of looking up items in theValueStackThe
DirectiveVelocityContextspecifically, enables applications greater flexibility in which capabilities they wish to leverage.ChainedVelocityContextandCompositeContextare useful utility contexts that can be used for general Velocity purposes.