WW-5533 Add compilation support for Jakarta EE 11 #1233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kusalk
force-pushed
the
WW-5533-jee11-supp
branch
from
b247751 to
97e08a7
Compare
kusalk
force-pushed
the
WW-5532-upg-deps
branch
from
ed111da to
077e985
Compare
kusalk
force-pushed
the
WW-5533-jee11-supp
branch
from
97e08a7 to
dfd54c9
Compare
kusalk
force-pushed
the
WW-5533-jee11-supp
branch
from
dfd54c9 to
720a8b6
Compare
kusalk
commented
Feb 25, 2025
plugins/tiles/src/main/java/org/apache/tiles/el/ScopeELResolver.java
Outdated
Show resolved
Hide resolved
lukaszlenart
approved these changes
Feb 25, 2025
plugins/tiles/src/main/java/org/apache/tiles/el/ScopeELResolver.java
Outdated
Show resolved
Hide resolved
kusalk
force-pushed
the
WW-5533-jee11-supp
branch
from
720a8b6 to
fa95171
Compare
kusalk
commented
Feb 25, 2025
| @@ -417,7 +417,6 @@ public void mismatchCharset() throws IOException { | |||
| assertThat(JakartaServletDiskFileUpload.isMultipartContent(mockRequest)).isTrue(); | |||
|
|
|||
| // when | |||
| mockRequest.setCharacterEncoding(null); | |||
There was a problem hiding this comment.
This is already null so can just delete it without affecting the test
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WW-5533
This PR adds an additional build job which ensures compilation compatibility with the upcoming Jakarta EE 11 and Spring 7. It ensures we do not make any code changes which may break forwards compatibility with those releases (e.g. using an API which no longer exists in Jakarta EE 11 or Spring 7).
By using a profile, we can continue to compile against both Jakarta EE 10 and 11, avoiding the need for separate release branches for as long as practical.
This change does NOT ensure compatibility with Tomcat 11.0. That will likely require a follow-up change where we update our Showcase app to use Tomcat 10.1 (and override to 11.0 when the Jakarta EE 11 profile is activated).
Open to feedback on this approach