[SPARK-50655][SS] Move virtual col family related mapping into db layer instead of encoder #49304
+628
−384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anishshri-db
changed the title
ericm-db
reviewed
Jan 2, 2025
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDB.scala
Outdated
Show resolved
Hide resolved
ericm-db
reviewed
Jan 2, 2025
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBFileManager.scala
Show resolved
Hide resolved
ericm-db
reviewed
Jan 2, 2025
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDB.scala
Outdated
Show resolved
Hide resolved
ericm-db
approved these changes
Jan 2, 2025
|
@HeartSaVioR - could you PTAL, thanks ! |
jingz-db
reviewed
Jan 3, 2025
| @@ -578,7 +578,11 @@ class RocksDBSuite extends AlsoTestWithRocksDBFeatures with SharedSparkSession | |||
|
|
|||
| if (isChangelogCheckpointingEnabled) { | |||
| assert(changelogVersionsPresent(remoteDir) === (1 to 50)) | |||
| assert(snapshotVersionsPresent(remoteDir) === Range.inclusive(5, 50, 5)) | |||
| if (colFamiliesEnabled) { | |||
There was a problem hiding this comment.
I might be missing something, but why will we get different results for snapshot with colFamiliesEnabled and disabled? I thought we are writing to the changelog the same way so this should be the same?
There was a problem hiding this comment.
Yea the only difference is that when we create a new col family - we force the snapshot creation by setting a flag. In the tests - we have to create this each time if there is no commit involved - hence we see the difference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Move virt col family related mapping into db layer instead of encoder
Why are the changes needed?
Keep abstraction clear around ownership and also expose internal/non-internal key metrics correctly.
With this change, we have the following:
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing Unit tests and added unit tests
Was this patch authored or co-authored using generative AI tooling?
No