-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SLING-12312 add jakarta.servlet support in RequestLocaleResolve #13
base: master
Are you sure you want to change the base?
Conversation
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This way the package has a dependency on both javax.servlet and jakarta.servlet and will not work for older environments. Was that the intention?
I would prefer to get rid of the javax.servlet (EE8) but that is not possible yet so both have to be there for now. Community support for all the versions of jetty that don't support EE9 or later have been eol for a while now. I guess I don't expect that people who don't upgrade anything and keep using eol software should get to decide what can be changed. Progress requires moving forward. org.apache.felix.http.jetty 5.x and org.apache.felix.http.jetty12 1.x both support servlets using either javax.servlet or jakarta.servlet Why can't the EE8 loyalists just stay on the old version of org.apache.sling.i18n? |
I don't think "loyalists" is the right term here. And we don't typically get to chose how our users manage their deployments. I'll start a dev@sling thread on this, I think it's important to have a clear policy. Edit: https://lists.apache.org/thread/l9vghkdgr3ddtc703drs38506oswlod8 |
Quality Gate passedIssues Measures |
provide a variant of the RequestLocaleResolver#resolveLocale call that accepts a jakarta.servlet.http.HttpServletRequest for use cases that have migrated to EE9 or later.