Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Potential fix for code scanning alert no. 22: HTTP response splitting #23976

Merged
merged 2 commits into from
Feb 13, 2025
+9 −1
Merged

[fix] Potential fix for code scanning alert no. 22: HTTP response splitting #23976

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f43df57
[fix] Potential fix for code scanning alert no. 22: HTTP response spl…
merlimat Feb 13, 2025
b64aaf3
Potential fix for code scanning alert no. 151: HTTP response splitting
merlimat Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion ...asl/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationProviderSasl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,7 @@ public boolean authenticateHttpRequest(HttpServletRequest request, HttpServletRe
} else {
checkState(request.getHeader(SASL_HEADER_STATE).equalsIgnoreCase(SASL_STATE_SERVER_CHECK_TOKEN));
setResponseHeaderState(response, SASL_STATE_COMPLETE);
response.setHeader(SASL_STATE_SERVER, request.getHeader(SASL_STATE_SERVER));
response.setHeader(SASL_STATE_SERVER, sanitizeHeaderValue(request.getHeader(SASL_STATE_SERVER)));
Fixed Show fixed Hide fixed
response.setStatus(HttpServletResponse.SC_OK);
if (log.isDebugEnabled()) {
log.debug("[{}] Server side role token verified success: {}", request.getRequestURI(),
Expand Down Expand Up @@ -325,4 +325,12 @@ public boolean authenticateHttpRequest(HttpServletRequest request, HttpServletRe
}
}
}

private String sanitizeHeaderValue(String value) {
if (value == null) {
return null;
}
// Remove CRLF and other special characters
return value.replaceAll("[\\r\\n]", "").replaceAll("[^\\x20-\\x7E]", "");
}
}
Loading