[fix] [client] call redeliver 1 msg but did 2 msgs #23943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Technoboy-
added
ready-to-test
and removed
doc-not-needed
shibd
approved these changes
Feb 7, 2025
dao-jun
approved these changes
Feb 7, 2025
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java
Outdated
Show resolved
Hide resolved
Technoboy-
approved these changes
Feb 8, 2025
gaoran10
approved these changes
Feb 8, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23943 +/- ##
============================================
+ Coverage 73.57% 74.25% +0.68%
+ Complexity 32624 2375 -30249
============================================
Files 1877 1853 -24
Lines 139502 143735 +4233
Branches 15299 16334 +1035
============================================
+ Hits 102638 106730 +4092
+ Misses 28908 28596 -312
- Partials 7956 8409 +453
Flags with carried forward coverage won't be shown. Click here to find out more.
|
BewareMyPower
pushed a commit
that referenced
this pull request
Feb 10, 2025
(cherry picked from commit 7a79c78)
poorbarcode
added a commit
that referenced
this pull request
Feb 11, 2025
(cherry picked from commit 7a79c78)
poorbarcode
added a commit
that referenced
this pull request
Feb 11, 2025
(cherry picked from commit 7a79c78)
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
Feb 11, 2025
(cherry picked from commit 7a79c78)
hanmz
pushed a commit
to hanmz/pulsar
that referenced
this pull request
Feb 12, 2025
|
@poorbarcode Could you fix the build error on the branch-3.0? This import is not used. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Issue: call redeliver
1message, but it will redeliver2messages, you can reproduce the issue by the new testtestBatchMessageNAckModifications
fix the bug
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: x