-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][broker] Avoid logging errors when there is a connection issue during subscription. #23939
Merged
BewareMyPower
merged 1 commit into
apache:master
from
RobertIndie:avoid-err-log-for-closed-conn
Feb 6, 2025
Merged
[improve][broker] Avoid logging errors when there is a connection issue during subscription. #23939
BewareMyPower
merged 1 commit into
apache:master
from
RobertIndie:avoid-err-log-for-closed-conn
Feb 6, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ue during subscription.
shibd
approved these changes
Feb 6, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23939 +/- ##
============================================
+ Coverage 73.57% 74.21% +0.63%
+ Complexity 32624 31802 -822
============================================
Files 1877 1853 -24
Lines 139502 143740 +4238
Branches 15299 16336 +1037
============================================
+ Hits 102638 106675 +4037
+ Misses 28908 28656 -252
- Partials 7956 8409 +453
Flags with carried forward coverage won't be shown. Click here to find out more.
|
BewareMyPower
approved these changes
Feb 6, 2025
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
Feb 10, 2025
…ue during subscription. (apache#23939) (cherry picked from commit 5e5d514)
hanmz
pushed a commit
to hanmz/pulsar
that referenced
this pull request
Feb 12, 2025
…ue during subscription. (apache#23939)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-picked/branch-3.0
cherry-picked/branch-3.3
cherry-picked/branch-4.0
doc-not-needed
Your PR changes do not impact docs
ready-to-test
release/3.0.10
release/3.3.5
release/4.0.3
type/enhancement
The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The broker currently logs an error if there's a temporary connection issue:
We can change this to a warning log level. This way, it won't clutter the broker log, and we can still track connection issues.
Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: