Improving logs and metric update logic #14762
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #14762 +/- ##
============================================
+ Coverage 61.75% 63.85% +2.10%
- Complexity 207 1608 +1401
============================================
Files 2436 2703 +267
Lines 133233 150741 +17508
Branches 20636 23290 +2654
============================================
+ Hits 82274 96263 +13989
- Misses 44911 47286 +2375
- Partials 6048 7192 +1144
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fetchLatestStreamOffset doesn't throw an exception when it's not able to fetch the latest offset.
The logs are not printed in case the consumer is not able to fetch the latest offset.
This PR improves the logs.
The current and latest offset metrics are set to null in case no messages are fetched.
Have updated the logic to pass currentOffset in case the offset doesn't change due to absence of messages.