[CI] fix issue with running scala-cli scripts #1752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pjfanning
commented
Jan 28, 2025
•
pjfanning
commented
- the CI action is not yet approved by ASF Infra team
- The main fix is to have the license header in the generated script appear after the CLI directives for the scala version and imports.
- fixes Java 11 compile issues in nightly build #1751
try to pin scala in scala-cli more hacking Update VerifyJDK9Classes.scala Update verify-jdk9-classes.sh update revert some changes Update nightly-builds.yml Update nightly-builds.yml
pjfanning
changed the title
raboof
reviewed
Jan 29, 2025
| echo "Starting verification with Scala-CLI..." | ||
|
|
||
| for file in stream/target/scala-cli/*.sc; do | ||
| cat $file |
There was a problem hiding this comment.
is this a debugging leftover? should it remain in?
There was a problem hiding this comment.
@raboof I think it is useful to have the generated script in the logs but if you think it best, I can remove this line,
There was a problem hiding this comment.
if it's intentional it's fine by me
raboof
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.