Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Make code compiles on JDK 23 #1726

Merged
merged 1 commit into from
Jan 17, 2025
Merged

chore: Make code compiles on JDK 23 #1726

merged 1 commit into from
Jan 17, 2025

Conversation

He-Pin
Copy link
Member

@He-Pin He-Pin commented Jan 17, 2025

Motivation:
Make code compiles on JDK 23
refs: #1725

Modification:
Add @nowarn("cat=deprecation")

Result:
Tested locally, it compiles now

@He-Pin He-Pin added this to the 1.2.0 milestone Jan 17, 2025
@He-Pin He-Pin linked an issue Jan 17, 2025 that may be closed by this pull request
@pjfanning
Copy link
Contributor

pjfanning commented Jan 17, 2025

I got this in the java 23 with scala 3 build

[01-17 20:08:03.894] [info] compiling 1 Scala source to /home/runner/work/pekko/pekko/actor/target/scala-3.3.4/CompileJdk9-classes ...
[01-17 20:08:03.905] [error] 23 is not a valid choice for -java-output-version
[01-17 20:08:03.906] [info]   scalac -help  gives more information
[01-17 20:08:03.906] [error] one error found

https://github.com/apache/pekko/actions/runs/12836052025/job/35796857450

@He-Pin
Copy link
Member Author

He-Pin commented Jan 17, 2025

@pjfanning Maybe we need to wait for the Scala 3.3.5?

Copy link
Contributor

@pjfanning pjfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - I think there is more to solve but this is a good start

@He-Pin
Copy link
Member Author

He-Pin commented Jan 17, 2025

@WojciechMazur I tested it with 3.3.5-RC1, but still later get:

[error] 23 is not a valid choice for -java-output-version
[info]   scalac -help  gives more information

@He-Pin He-Pin merged commit a75bc7a into apache:main Jan 17, 2025
9 checks passed
@He-Pin He-Pin deleted the java23 branch January 17, 2025 21:28
@WojciechMazur
Copy link
Contributor

@He-Pin Thank you for spotting this bug! The JDK 23 support was backported to 3.3.5-RC1, by mistake 1 single change that is no longer needed in Next was not applied in the LTS backport. We're release 3.3.5-RC3 with a fix on Monday

@He-Pin
Copy link
Member Author

He-Pin commented Jan 17, 2025

Is the 3.3.5-RC2 on the way, so next is 3.3.5-RC3? @WojciechMazur

@WojciechMazur
Copy link
Contributor

Correct, it was going to be announced on Monday, becouse we're waiting for tooling confirmation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make code compiles on JDK 23
3 participants