Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scalafmt-core to 3.8.4 #1717

Merged
merged 4 commits into from
Jan 18, 2025
Merged

Update scalafmt-core to 3.8.4 #1717

merged 4 commits into from
Jan 18, 2025

Conversation

scala-steward-asf[bot]
Copy link
Contributor

About this PR

πŸ“¦ Updates org.scalameta:scalafmt-core from 3.8.3 to 3.8.4

πŸ“œ GitHub Release Notes - Version Diff

Usage

βœ… Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

βš™ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.scalameta", artifactId = "scalafmt-core" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.scalameta", artifactId = "scalafmt-core" }
}]
labels: library-update, early-semver-patch, semver-spec-patch, commit-count:n:3

@raboof
Copy link
Member

raboof commented Jan 15, 2025

Looks like since scalafmt 3.8.4, the AvoidInfix rule will also change postfixOps 5 seconds to 5.seconds

We can exclude that with rewrite.avoidInfix.excludePostfix = true in the scalafmt config.

'5 seconds' looks slightly nicer, but it's also a bit unusual. I'd be OK with writing 5.seconds from now on. WDYT?

@pjfanning
Copy link
Contributor

We are also getting compile issues like

[error] /home/runner/work/pekko/pekko/testkit/src/main/scala/org/apache/pekko/testkit/CallingThreadDispatcher.scala:26:17: Unused import
[error] import language.postfixOps
[error]                 ^
[error] /home/runner/work/pekko/pekko/testkit/src/main/scala/org/apache/pekko/testkit/TestKit.scala:24:23: Unused import
[error] import scala.language.postfixOps
[error]                       ^
[error] two errors found

Assuming we want to keep the default
`rewrite.avoidInfix.excludePostfix = false` - otherwise
we can drop this commit
Copy link
Member

@He-Pin He-Pin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@He-Pin He-Pin merged commit 5b2aab6 into main Jan 18, 2025
9 checks passed
@He-Pin He-Pin deleted the update/scalafmt-core-3.8.4 branch January 18, 2025 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants