chore: Add support for controlling the NettyTransport's byteBuf allocator type. #1707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
He-Pin
force-pushed
the
byteBufAllocator
branch
from
7230af8 to
5a4a9a0
Compare
pjfanning
reviewed
Jan 13, 2025
remote/src/main/scala/org/apache/pekko/remote/transport/netty/NettyTransport.scala
Outdated
Show resolved
Hide resolved
He-Pin
requested review from
pjfanning,
raboof,
mdedetrich,
gmethvin,
nvollmar,
seglo,
samueleresca and
Roiocam
|
@pjfanning Wdyt about backpacking this to 1.1.x？ |
Maybe. Let's see what other people say about the PR. Even if we do backport it, we would still need to do a release and are Flink team that interested in this? |
|
@a1kemist asked for this. |
He-Pin
added a commit
to He-Pin/incubator-pekko
that referenced
this pull request
Jan 14, 2025
…ator type. (apache#1707) * chore: Add support for controlling the NettyTransport's byteBuf allocator type. * chore: extract deriveByteBufAllocator method (cherry picked from commit dbc9ed3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
As a response to apache/flink#25866
@davidradl @afedulov want to control the bytebuf allocator type.
Modification:
Add
bytebuf-allocator-typeselector , withpooledby default.Result:
The bytebuf allocator can be configured now.