Skip to content

Commit

Permalink
add types for implicits (#78)
Browse files Browse the repository at this point in the history
  • Loading branch information
pjfanning authored Aug 15, 2023
1 parent 5a4b9f1 commit 7865b14
Show file tree
Hide file tree
Showing 10 changed files with 13 additions and 14 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ import pekko.persistence.jdbc.config.DurableStateTableConfiguration
case _ => ???
}

implicit val uuidSetter = SetParameter[Array[Byte]] { case (bytes, params) =>
implicit val uuidSetter: SetParameter[Array[Byte]] = SetParameter[Array[Byte]] { case (bytes, params) =>
params.setBytes(bytes)
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import scala.concurrent.duration._
import org.scalatest.matchers.should.Matchers

abstract class HardDeleteQueryTest(config: String) extends QueryTestSpec(config) with Matchers {
implicit val askTimeout = 500.millis
implicit val askTimeout: FiniteDuration = 500.millis

it should "not return deleted events when using CurrentEventsByTag" in withActorSystem { implicit system =>
val journalOps = new ScalaJdbcReadJournalOperations(system)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ abstract class JournalDaoStreamMessagesMemoryTest(configFile: String)
val journalSequenceActorConfig = readJournalConfig.journalSequenceRetrievalConfiguration
val journalTableCfg = journalConfig.journalTableConfiguration

implicit val askTimeout = 50.millis
implicit val askTimeout: FiniteDuration = 50.millis

def generateId: Int = 0

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ abstract class JournalSequenceActorTest(configFile: String, isOracle: Boolean)

import profile.api._

implicit val askTimeout = 50.millis
implicit val askTimeout: FiniteDuration = 50.millis

def generateId: Int = 0

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,9 @@ import pekko.stream.testkit.javadsl.{ TestSink => JavaSink }
import pekko.stream.testkit.scaladsl.TestSink
import pekko.stream.{ Materializer, SystemMaterializer }
import com.typesafe.config.ConfigValue
import scala.concurrent.Future
import scala.concurrent.duration.{ FiniteDuration, _ }

import scala.concurrent.{ ExecutionContext, Future }
import scala.concurrent.duration.{ FiniteDuration, _ }
import pekko.persistence.jdbc.testkit.internal.H2
import pekko.persistence.jdbc.testkit.internal.MySQL
import pekko.persistence.jdbc.testkit.internal.Oracle
Expand Down Expand Up @@ -331,7 +331,7 @@ abstract class QueryTestSpec(config: String, configOverrides: Map[String, Config
def expectAllStarted(refs: Seq[ActorRef])(implicit system: ActorSystem): Unit = {
// make sure we notice early if the actors failed to start (because of issues with journal) makes debugging
// failing tests easier as we know it is not the actual interaction from the test that is the problem
implicit val ec = system.dispatcher
implicit val ec: ExecutionContext = system.dispatcher
Future.sequence(refs.map(_ ? "state")).futureValue
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ object TestProbeReadJournalDao {
*/
class TestProbeReadJournalDao(val probe: TestProbe) extends ReadJournalDao {
// Since the testprobe is instrumented by the test, it should respond very fast
implicit val askTimeout = Timeout(100.millis)
implicit val askTimeout: Timeout = Timeout(100.millis)

/**
* Returns distinct stream of persistenceIds
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,9 @@

package org.apache.pekko.persistence.jdbc.state

import scala.concurrent.Future
import scala.concurrent.{ ExecutionContext, Future }
import org.apache.pekko
import pekko.actor.ActorSystem
import pekko.actor.ActorSystem
import pekko.Done
import org.scalatest.concurrent.ScalaFutures
import org.scalatest.matchers.should.Matchers
Expand Down Expand Up @@ -61,7 +60,7 @@ object ScaladslSnippets extends ScalaFutures with Matchers {

def upsertAndGetObject(): Unit = {
implicit val system: ActorSystem = ActorSystem()
implicit val e = system.dispatcher
implicit val e: ExecutionContext = system.dispatcher

// #upsert-get-object
import org.apache.pekko
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ abstract class DurableStateSequenceActorTest(config: Config, schemaType: SchemaT

val durableStateSequenceActorConfig = durableStateConfig.stateSequenceConfig

implicit val askTimeout = 50.millis
implicit val askTimeout: FiniteDuration = 50.millis
implicit val timeout: Timeout = Timeout(1.minute)

"A DurableStateSequenceActor" must {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ abstract class StateSpecBase(val config: Config, schemaType: SchemaType)
lazy val durableStateConfig = new DurableStateTableConfiguration(cfg)
lazy val serialization = SerializationExtension(system)

implicit val defaultPatience =
implicit val defaultPatience: PatienceConfig =
PatienceConfig(timeout = Span(60, Seconds), interval = Span(100, Millis))

def withActorSystem(f: ExtendedActorSystem => Unit): Unit = {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ class TestProbeDurableStateStoreQuery(
serialization: Serialization)(override implicit val system: ExtendedActorSystem)
extends JdbcDurableStateStore[String](db, profile, durableStateConfig, serialization)(system) {

implicit val askTimeout = Timeout(100.millis)
implicit val askTimeout: Timeout = Timeout(100.millis)

override def getObject(persistenceId: String): Future[GetObjectResult[String]] = ???
override def currentChanges(tag: String, offset: Offset): Source[DurableStateChange[String], NotUsed] = ???
Expand Down

0 comments on commit 7865b14

Please sign in to comment.