Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more work on fixing dependency-graph CI job #190

Closed
wants to merge 4 commits into from
Closed

Conversation

pjfanning
Copy link
Contributor

@pjfanning pjfanning commented Jan 1, 2025

@pjfanning pjfanning marked this pull request as draft January 1, 2025 11:21
@pjfanning pjfanning marked this pull request as ready for review January 1, 2025 11:46
@samueleresca
Copy link
Member

samueleresca commented Jan 1, 2025

In ubuntu-latest (ubuntu-24.04) is running Java 17 as the default option.. I think Java 17 do not support this flag anymore: -XX:+CMSClassUnloadingEnabled. Therefore, it breaks. I'm not sure if -XX:+CMSClassUnloadingEnabled can be removed

@samueleresca
Copy link
Member

samueleresca commented Jan 1, 2025

The reason why was working on the original PR is because it was running on Ubuntu 22.04. I think they are switching ubuntu-latest to Ubuntu 24.04 as we speak:

This change will be rolled out over a period of several weeks beginning December 5th and will complete on January 17th, 2025.

We might experience more pipeline flakiness in the other Pekko repos if we have JVM configs that have been deprecated between versions

@pjfanning pjfanning marked this pull request as draft January 1, 2025 12:31
@pjfanning
Copy link
Contributor Author

CMSClassUnloadingEnabled.

I don't know where this comes from. scalacenter/sbt-dependency-submission does not seem to set it. Maybe sbt does?

@samueleresca
Copy link
Member

CMSClassUnloadingEnabled.

I don't know where this comes from. scalacenter/sbt-dependency-submission does not seem to set it. Maybe sbt does?

That option is coming from the .jvmopts file in this repo. I think scalacenter/sbt-dependency-submission picks up that

@pjfanning pjfanning closed this Jan 1, 2025
@pjfanning pjfanning deleted the pjfanning-patch-3 branch January 1, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants