Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPENNLP-1626: Update Website with new models (1.1) #87

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

mawiesne
Copy link
Contributor

@mawiesne mawiesne commented Oct 28, 2024

Change

  • updates models.ad to cover all new 18 languages
  • restructures models.ad for better separation and readability of long tables
  • reduces information duplication / overhead
  • adds better CSS styling for TOC formatting
  • adds TOC directives to several pages where helpful
  • fixes several occasions of incorrectly chosen section/subsection depths, in download.ad, maven-dependency.ad and gradle-dependency.ad
  • adds news entry for the models release 1.1 (2024-10-28)

@mawiesne mawiesne self-assigned this Oct 28, 2024
@mawiesne mawiesne changed the title OPENNLP-1626 Update Website with new models (1.1) OPENNLP-1626: Update Website with new models (1.1) Oct 28, 2024
Copy link
Contributor

@rzo1 rzo1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, but there is a slight URL replacement required for hashes / asc signatures to comply with ASF (download page) standards.

@mawiesne mawiesne force-pushed the OPENNLP-1626-Update-Website-with-new-models-(1.1) branch from a186d00 to 08e9c32 Compare October 28, 2024 20:49
@mawiesne mawiesne requested a review from rzo1 October 28, 2024 20:49
- updates models.ad to cover all new 18 languages
- restructures models.ad for better separation and readability of long tables
- reduces information duplication / overhead
- adds better CSS styling for TOC formatting
- adds TOC directives to several pages where helpful
- fixes several occasions of incorrectly chosen section/subsection depths, in download.ad, maven-dependency.ad and gradle-dependency.ad
- adds news entry for the models release 1.1 (2024-10-28)
@mawiesne mawiesne force-pushed the OPENNLP-1626-Update-Website-with-new-models-(1.1) branch from 08e9c32 to c5d931a Compare October 28, 2024 21:03
@mawiesne mawiesne merged commit a4c1ae1 into main Oct 29, 2024
1 check passed
@mawiesne mawiesne deleted the OPENNLP-1626-Update-Website-with-new-models-(1.1) branch October 29, 2024 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants