-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(WIP) ci(bindings/go): add windows to matrix #5066
base: main
Are you sure you want to change the base?
Conversation
626fb26
to
125a18f
Compare
125a18f
to
6366323
Compare
Hi, @yuchanns, would you like to take a review? |
6366323
to
f5f95cb
Compare
It failed at
IMO the pwsh doesn't support |
While it comes to the step - name: Build C Binding
working-directory: bindings/c
env:
VERSION: "latest"
SERVICE: ${{ matrix.service }}
TARGET: ${{ matrix.build.target }}
CC: ${{ matrix.build.cc }}
OS: ${{ matrix.build.os }}
run: |
cargo build --target $TARGET --release
DIR=$GITHUB_WORKSPACE/libopendal_c_${VERSION}_${SERVICE}_$TARGET
mkdir $DIR
if [ ${OS} == 'ubuntu-latest' ]; then
SO=so
# Add SO=dll
else
SO=dylib
fi |
@yuchanns Thanks, I will test it in my Windows Computer :) |
6a4858b
to
08328f8
Compare
@yuchanns Any idea about this? I think I am close. It compiles
|
08328f8
to
1fef79b
Compare
I think renaming it should just works. |
f0ea5c1
to
5becbde
Compare
Signed-off-by: Zhangjian He <[email protected]>
5becbde
to
ddbdae2
Compare
@yuchanns Sorry, can you give me some hint about this error?
|
Oops! That's an arch issue. Something needs to be solved in the go-services repo. There's no *_windows.go file now. I'll take a look tomorrow. |
@yuchanns Could you please give me a chance to try? I would like to try to deep look |
Sure. It's yours:) |
Just for remind:
The respective function in Windows is windows.UTF16PtrFromString. FYI: https://pkg.go.dev/golang.org/x/sys/windows Maybe you can create a set of
And export |
Did you use Go Workspace to develop? Please follow the instructions of https://github.com/apache/opendal/tree/main/bindings/go#development. Go Workspace is essential to development across opendal and opendal-go-services. During the development of the Go binding, we do not rely on artifacts released by opendal-go-services. Instead, we build the latest artifacts from opendal-go-services within the Go Workspace. This is likely why you encountered the error below: there are currently no releases for Windows platform artifacts.
A positive example is that there are no releases for MacOS artifacts, yet the tests still work because Go Workspace newly generates the artifacts. |
Main Issue #4892