Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compile error. #15683

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Fix compile error. #15683

merged 1 commit into from
Jan 24, 2025

Conversation

wangzhi-art
Copy link
Contributor

Note: Please adhere to Contributing Guidelines.

Summary

fix compile error
CC: socket/listen.c chip/lpc17_40_i2c.c: In function 'lpc17_40_i2cbus_initialize': chip/lpc17_40_i2c.c:534:29: warning: 'priv' is used uninitialized [-Wuninitialized]
534 | flags = spin_lock_irqsave(&priv->spinlock);
| ^~~~~~~~~~~~~~~
chip/lpc17_40_i2c.c:529:29: note: 'priv' was declared here
529 | struct lpc17_40_i2cdev_s *priv;
| ^~~~

Impact

none

Testing

CI

@github-actions github-actions bot added Arch: arm Issues related to ARM (32-bit) architecture Size: S The size of the change in this PR is small labels Jan 24, 2025
@nuttxpr
Copy link

nuttxpr commented Jan 24, 2025

[Experimental Bot, please feedback here]

No, this PR does not fully meet the NuttX requirements. While it provides a summary of the issue and indicates testing through CI, it lacks crucial information.

Here's what's missing:

  • Summary: Needs more detail. Why was there a compile error? How was it fixed? What exactly changed in the code? A link to the related NuttX issue should be included.
  • Impact: While stating "none" is acceptable if truly no impact, it's unlikely a compile error fix has zero impact. At minimum, the build process was previously broken and is now fixed, so "Impact on build: YES (Fixed compile error that prevented successful build)" is more appropriate.
  • Testing: "CI" is insufficient. While CI testing is important, the PR should demonstrate local testing verification. This requires specifying the build host and target environment, along with providing specific "before" and "after" testing logs demonstrating the fix. Simply saying "compile error" doesn't show that the intended functionality now works correctly. Show the previous error message and the successful compilation/execution after the fix.

The submitter needs to expand on these sections to meet the NuttX PR requirements. A more complete example would be beneficial for reviewers.

CC: socket/listen.c chip/lpc17_40_i2c.c: In function 'lpc17_40_i2cbus_initialize': chip/lpc17_40_i2c.c:534:29: warning: 'priv' is used uninitialized [-Wuninitialized]
534 | flags = spin_lock_irqsave(&priv->spinlock);
| ^~~~~~~~~~~~~~~
chip/lpc17_40_i2c.c:529:29: note: 'priv' was declared here
529 | struct lpc17_40_i2cdev_s *priv;
| ^~~~

Signed-off-by: wangzhi16 <[email protected]>
@xiaoxiang781216 xiaoxiang781216 merged commit 60df0cd into apache:master Jan 24, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Arch: arm Issues related to ARM (32-bit) architecture Size: S The size of the change in this PR is small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] lpcxpresso-lpc54628/nsh fails to build: 'priv' is used uninitialized (spin_lock_irqsave)
4 participants