Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "mm_heap: double malloced memory default alignment (4 -> 8, 8 -> 16)" #15462

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

W-M-R
Copy link
Contributor

@W-M-R W-M-R commented Jan 8, 2025

Note: Please adhere to Contributing Guidelines.

Summary

mm: default mm align 32->4,64->8

Impact

The modification at that time was because of x86-64, but the problem has been fixed elsewhere, and other architectures will not encounter any problems for the time being.

Testing

Update this section with details on how did you verify the change,
what Host was used for build (OS, CPU, compiler, ..), what Target was
used for verification (arch, board:config, ..), etc. Providing build
and runtime logs from before and after change is highly appreciated.

@github-actions github-actions bot added Area: Memory Management Memory Management issues Size: XS The size of the change in this PR is very small labels Jan 8, 2025
@yamt
Copy link
Contributor

yamt commented Jan 8, 2025

mm: default mm align 32->4,64->8

do you mean 8->4, 16->8?

The modification at that time was because of x86-64, but the problem has been fixed elsewhere, and other architectures will not encounter any problems for the time being.

can you add a reference to the "elsewhere"?

@W-M-R W-M-R changed the title mm: default mm align 32->4,64->8 mm: Change mm_align to 4-byte alignment for 32-bit and 8-byte alignment for 64-bit Jan 8, 2025
@W-M-R
Copy link
Contributor Author

W-M-R commented Jan 8, 2025

mm: default mm align 32->4,64->8

do you mean 8->4, 16->8?

The modification at that time was because of x86-64, but the problem has been fixed elsewhere, and other architectures will not encounter any problems for the time being.

can you add a reference to the "elsewhere"?

It is this patch "#8734". The change was made because x64 failed to start when 8-byte alignment was required, but I don't know how it was fixed. After reverting, x64 is fine.It was mentioned here at "#8721"

@W-M-R W-M-R changed the title mm: Change mm_align to 4-byte alignment for 32-bit and 8-byte alignment for 64-bit Revert "mm_heap: double malloced memory default alignment (4 -> 8, 8 -> 16)" Jan 8, 2025
@xiaoxiang781216 xiaoxiang781216 merged commit 11d54b3 into apache:master Jan 8, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Memory Management Memory Management issues Size: XS The size of the change in this PR is very small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants