Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(#3239) NPE, for RegexFilter creator. #3265

Open
wants to merge 1 commit into
base: 2.x
Choose a base branch
from
Open

Fix(#3239) NPE, for RegexFilter creator. #3265

wants to merge 1 commit into from

Conversation

jaykataria1111
Copy link
Contributor

fix for #3239

Checklist

  • Base your changes on 2.x branch if you are targeting Log4j 2; use main otherwise
  • ./mvnw verify succeeds (if it fails due to code formatting issues reported by Spotless, simply run ./mvnw spotless:apply and retry)
  • Non-trivial changes contain an entry file in the src/changelog/.2.x.x directory
  • Tests for the changes are provided
  • Commits are signed (optional, but highly recommended)

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024

Job Requested goals Build Tool Version Build Outcome Build Scan®
build-macos-latest clean install 3.9.8 ✅ Build Scan PUBLISHED
build-ubuntu-latest clean install 3.9.8 ✅ Build Scan PUBLISHED
build-windows-latest clean install 3.9.8 ✅ Build Scan PUBLISHED
Generated by gradle/develocity-actions

ppkarwasz
ppkarwasz reviewed Dec 3, 2024
View reviewed changes
Copy link
Contributor

@ppkarwasz ppkarwasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaykataria1111,

Can you add a unit test to see if createFilter does not throw with all parameters (except regex) equal to null?

log4j-core/src/main/java/org/apache/logging/log4j/core/filter/RegexFilter.java Outdated Show resolved Hide resolved
@ppkarwasz ppkarwasz self-assigned this Dec 4, 2024
@jaykataria1111
Copy link
Contributor Author

@ppkarwasz added the test, and updated the code :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppkarwasz ppkarwasz ppkarwasz left review comments

@jvz jvz jvz approved these changes

Assignees

@ppkarwasz ppkarwasz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaykataria1111 @jvz @ppkarwasz