KAFKA-18598 Remove ControllerMetadataMetrics zk related Metrics #18629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clolov
approved these changes
Jan 20, 2025
|
Thanks for fixing the failing test! Merged, I will also look into putting this in the 4.0 branch which as far as I understand is what we would like to do with all changes of this nature! |
clolov
pushed a commit
that referenced
this pull request
Jan 22, 2025
) Reviewers: Christo Lolov <[email protected]>
pranavt84
pushed a commit
to pranavt84/kafka
that referenced
this pull request
Jan 27, 2025
…che#18629) Reviewers: Christo Lolov <[email protected]>
airlock-confluentinc bot
pushed a commit
to confluentinc/kafka
that referenced
this pull request
Jan 27, 2025
…che#18629) Reviewers: Christo Lolov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://issues.apache.org/jira/browse/KAFKA-18598
These metrics is unused in Kraft mode, It doesn't return the correct number, thus we should remove these metrics.
Committer Checklist (excluded from commit message)