KAFKA-18383: Remove reserved.broker.max.id, broker.id.generation.enable, and broker.id #18478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
FrankYang0529
force-pushed
the
KAFKA-18383
branch
from
c95743d to
418d94a
Compare
chia7712
reviewed
Jan 18, 2025
| @@ -376,7 +376,7 @@ RemoteStorageManager createRemoteStorageManager() { | |||
|
|
|||
| private void configureRSM() { | |||
| final Map<String, Object> rsmProps = new HashMap<>(rlmConfig.remoteStorageManagerProps()); | |||
| rsmProps.put(ServerConfigs.BROKER_ID_CONFIG, brokerId); | |||
| rsmProps.put(KRaftConfigs.NODE_ID_CONFIG, brokerId); | |||
There was a problem hiding this comment.
remote storage is using broker.id rather than node.id. see
maybe we should align the naming for this internal config. @showuon FYI
FrankYang0529
force-pushed
the
KAFKA-18383
branch
4 times, most recently
from
938b911 to
5b685dc
Compare
…le, and broker.id Signed-off-by: PoAn Yang <[email protected]>
FrankYang0529
force-pushed
the
KAFKA-18383
branch
from
5b685dc to
273c29f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ZK mode is removed in 4.0, so we can remove related configuration as well.
Committer Checklist (excluded from commit message)