Use instanceof pattern to avoid explicit cast
#18373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
mumrah
approved these changes
Jan 2, 2025
There was a problem hiding this comment.
Thanks @ijuma. Looking forward to all the modern Java conveniences :)
Out of curiosity, I tried making a similar change in the clients module. IntelliJ correctly warns me that the language level is set to 11. Gradle gives a similar error.
LGTM
|
@mumrah Yes, I used IntelliJ's analysis to make the changes and it's smart enough to only suggest them if the Java version for the relevant module can handle them. |
ijuma
added a commit
that referenced
this pull request
Jan 2, 2025
This feature was introduced in Java 16. Reviewers: David Arthur <[email protected]>, Apoorv Mittal <[email protected]>
airlock-confluentinc bot
pushed a commit
to confluentinc/kafka
that referenced
this pull request
Jan 3, 2025
This feature was introduced in Java 16. Reviewers: David Arthur <[email protected]>, Apoorv Mittal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature was introduced in Java 16.
Committer Checklist (excluded from commit message)