Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: Use Files.readString/writeString and String.repeat to simplify code #18372

Merged
merged 2 commits into from
Jan 3, 2025

Conversation

ijuma
Copy link
Member

@ijuma ijuma commented Jan 1, 2025

The 3 methods were introduced in Java 11.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@ijuma
Copy link
Member Author

ijuma commented Jan 1, 2025

@mimaison Do you have cycles to review this?

@ijuma ijuma requested a review from mimaison January 1, 2025 18:13
@github-actions github-actions bot added streams core Kafka Broker consumer tools storage Pull requests that target the storage module generator RPC and Record code generator clients small Small PRs labels Jan 1, 2025
@ijuma ijuma force-pushed the string-files-newer-java branch from 96001e6 to bb98fb1 Compare January 1, 2025 18:15
@ijuma ijuma merged commit 73ab7ee into apache:trunk Jan 3, 2025
9 checks passed
airlock-confluentinc bot pushed a commit to confluentinc/kafka that referenced this pull request Jan 3, 2025
…lify code (apache#18372)

The 3 methods were introduced in Java 11.

Reviewers: Divij Vaidya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clients consumer core Kafka Broker generator RPC and Record code generator small Small PRs storage Pull requests that target the storage module streams tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants