Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAFKA-18374 Remove unused EncryptingPasswordEncoder #18355

Merged
merged 2 commits into from
Jan 6, 2025
Merged

KAFKA-18374 Remove unused EncryptingPasswordEncoder #18355

merged 2 commits into from
Jan 6, 2025

Conversation

mingdaoy
Copy link
Contributor

https://issues.apache.org/jira/browse/KAFKA-18374

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@github-actions github-actions bot added triage PRs from the community core Kafka Broker labels Dec 30, 2024
@chia7712
Copy link
Member

@mingdaoy could you please remove CipherParamsEncoder, GcmParamsEncoder, IvParamsEncoder, and the unused static variables in PasswordEncoder?

@mingdaoy
Copy link
Contributor Author

PasswordEncoder is used in core/src/main/scala/kafka/server/DynamicBrokerConfig.scala. Should we keep this? What are your thoughts?

https://github.com/mingdaoy/kafka/blob/3161115adae4de9f2b2ec6b87462ea10a8993456/core/src/main/scala/kafka/server/DynamicBrokerConfig.scala#L414

@github-actions github-actions bot removed the triage PRs from the community label Jan 1, 2025
chia7712
chia7712 reviewed Jan 4, 2025
View reviewed changes
Copy link
Member

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mingdaoy could you please remove base64Encode and base64Decode too?

FrankYang0529
FrankYang0529 reviewed Jan 4, 2025
View reviewed changes
Copy link
Member

@FrankYang0529 FrankYang0529 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave a minor comment.

server-common/src/main/java/org/apache/kafka/security/PasswordEncoder.java Outdated
@@ -22,16 +22,6 @@
import java.util.Base64;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line can be removed as well.

@mingdaoy
KAFKA-18374 Remove EncryptingPasswordEncoder, CipherParamsEncoder, Gc…
8903cf5 
…mParamsEncoder, IvParamsEncoder, and the unused static variables in PasswordEncoder
FrankYang0529
FrankYang0529 approved these changes Jan 4, 2025
View reviewed changes
Copy link
Member

@FrankYang0529 FrankYang0529 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the patch.

clolov
clolov approved these changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@clolov clolov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this change! Restarting the unit test run!

@clolov clolov self-assigned this Jan 6, 2025
@chia7712 chia7712 merged commit 23e77ed into apache:trunk Jan 6, 2025
9 checks passed
chia7712 pushed a commit that referenced this pull request Jan 6, 2025
@mingdaoy @chia7712
KAFKA-18374 Remove EncryptingPasswordEncoder, CipherParamsEncoder, Gc…
01dcba5 
…mParamsEncoder, IvParamsEncoder, and the unused static variables in PasswordEncoder (#18355)

Reviewers: TengYao Chi <[email protected]>, TaiJuWu <[email protected]>, Christo Lolov <[email protected]>, PoAn Yang <[email protected]>, Chia-Ping Tsai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankvicky frankvicky frankvicky approved these changes

@TaiJuWu TaiJuWu TaiJuWu approved these changes

@clolov clolov clolov approved these changes

@chia7712 chia7712 chia7712 approved these changes

@FrankYang0529 FrankYang0529 FrankYang0529 approved these changes

Assignees

@clolov clolov

Labels
ci-approved core Kafka Broker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mingdaoy @chia7712 @FrankYang0529 @clolov @TaiJuWu @frankvicky