-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix kie-issues #1236 - Replace quay.io with docker.io, review version.go #466
Conversation
@jstastny-cz I think we need to align the Jenkins CI part, since the weekly I guess we will publish the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small typos
config/manifests/bases/sonataflow-operator.clusterserviceversion.yaml
Outdated
Show resolved
Hide resolved
@thiagoelg please remove the request for changes e2e is failing duo to the images renaming |
It seems that it's failing with a similar error we got on kie-tools, this change might fix it: apache/incubator-kie-tools#2347 |
@thiagoelg thanks! It worked: #469 I'm gonna rebase it. |
Signed-off-by: Ricardo Zanini <[email protected]>
Signed-off-by: Ricardo Zanini <[email protected]>
Signed-off-by: Ricardo Zanini <[email protected]>
2d74b7c
to
753df2f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@ricardozanini can we merge this PR? We need to merge this one and the #494 to unblock the seed jobs on Apache Jenkins |
@rodrigonull sure, we just need @thiagoelg to remove the "require changes" review. The merge is blocked until there. |
….go (apache#466) * Fix kie-issues #1236 - Replace quay.io with docker.io, review version.go Signed-off-by: Ricardo Zanini <[email protected]> * Fix env.sh and bump-version.sh scripts Signed-off-by: Ricardo Zanini <[email protected]> * Fix small typos Signed-off-by: Ricardo Zanini <[email protected]> --------- Signed-off-by: Ricardo Zanini <[email protected]>
Description of the change:
Fixes apache/incubator-kie-issues#1236
Motivation for the change:
We need to realign the images with docker.io in order to release under Apache.
Checklist
How to backport a pull request to a different branch?
In order to automatically create a backporting pull request please add one or more labels having the following format
backport-<branch-name>
, where<branch-name>
is the name of the branch where the pull request must be backported to (e.g.,backport-7.67.x
to backport the original PR to the7.67.x
branch).Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.