Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kie-issues #1236 - Replace quay.io with docker.io, review version.go #466

Merged
merged 3 commits into from
Jun 20, 2024

Conversation

ricardozanini
Copy link
Member

Description of the change:
Fixes apache/incubator-kie-issues#1236

Motivation for the change:
We need to realign the images with docker.io in order to release under Apache.

Checklist

  • Add or Modify a unit test for your change
  • Have you verified that tall the tests are passing?
How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

@ricardozanini ricardozanini requested a review from wmedvede May 17, 2024 18:55
@ricardozanini
Copy link
Member Author

@tiagobento @thiagoelg fyi

@ricardozanini
Copy link
Member Author

@jstastny-cz I think we need to align the Jenkins CI part, since the weekly I guess we will publish the main tag, right? And the release, the operatorVersion.

Copy link
Member

@thiagoelg thiagoelg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small typos

@ricardozanini
Copy link
Member Author

@thiagoelg please remove the request for changes

e2e is failing duo to the images renaming

@thiagoelg
Copy link
Member

@thiagoelg please remove the request for changes

e2e is failing duo to the images renaming

It seems that it's failing with a similar error we got on kie-tools, this change might fix it: apache/incubator-kie-tools#2347

@thiagoelg thiagoelg self-requested a review May 22, 2024 21:56
@ricardozanini
Copy link
Member Author

@thiagoelg thanks! It worked: #469

I'm gonna rebase it.

Copy link
Contributor

@jstastny-cz jstastny-cz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@rodrigonull
Copy link
Contributor

@ricardozanini can we merge this PR? We need to merge this one and the #494 to unblock the seed jobs on Apache Jenkins

@ricardozanini
Copy link
Member Author

@rodrigonull sure, we just need @thiagoelg to remove the "require changes" review. The merge is blocked until there.

@ricardozanini ricardozanini merged commit a2ac28d into apache:main Jun 20, 2024
6 of 7 checks passed
@ricardozanini ricardozanini deleted the kie-issues-1217 branch June 20, 2024 14:17
rgdoliveira pushed a commit to rgdoliveira/kogito-serverless-operator that referenced this pull request Jul 8, 2024
….go (apache#466)

* Fix kie-issues #1236 - Replace quay.io with docker.io, review version.go

Signed-off-by: Ricardo Zanini <[email protected]>

* Fix env.sh and bump-version.sh scripts

Signed-off-by: Ricardo Zanini <[email protected]>

* Fix small typos

Signed-off-by: Ricardo Zanini <[email protected]>

---------

Signed-off-by: Ricardo Zanini <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop using "latest" tags on kogito-serverless-operator and default the "development stream name"
5 participants