This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 593
Travis CI to test that website links are valid #709
Merged
billonahill
merged 16 commits into
apache:master
from
billonahill:billg/travis_docs_check_2
May 20, 2016
Merged
Travis CI to test that website links are valid #709
billonahill
merged 16 commits into
apache:master
from
billonahill:billg/travis_docs_check_2
May 20, 2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
||
#linkchecker removes previous runs. | ||
pip install linkchecker | ||
which linkchecker || pip install linkchecker |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest moving this into the Makefile
so that make setup
covers this. I think that's a bit cleaner.
Good call @lucperkins done. Also added a link to the linkchecker issue: |
+1 |
This was referenced May 20, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verifies that links in the website docs are valid.
I've confirmed that this will cause the build to fail upon bad links. Since we currently have bad links the feature is disabled but once we fix the existing broken links we can enable this as described in
.travis.yml
.