Skip to content

Commit

Permalink
170 PR comment changes + clang-format-8
Browse files Browse the repository at this point in the history
  • Loading branch information
lepto2014 committed Jun 12, 2024
1 parent 16a7326 commit 6289efc
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 8 deletions.
9 changes: 4 additions & 5 deletions cpp/src/filesystem.cc
Original file line number Diff line number Diff line change
Expand Up @@ -172,8 +172,8 @@ Result<T> FileSystem::ReadFileToValue(const std::string& path) const noexcept {
}

template <>
Result<std::string> FileSystem::ReadFileToValue(const std::string& path) const
noexcept {
Result<std::string> FileSystem::ReadFileToValue(
const std::string& path) const noexcept {
GAR_RETURN_ON_ARROW_ERROR_AND_ASSIGN(auto access_file,
arrow_fs_->OpenInputFile(path));
GAR_RETURN_ON_ARROW_ERROR_AND_ASSIGN(auto bytes, access_file->GetSize());
Expand Down Expand Up @@ -311,7 +311,6 @@ Result<std::shared_ptr<FileSystem>> FileSystemFromUriOrPath(
template Result<IdType> FileSystem::ReadFileToValue<IdType>(
const std::string&) const noexcept;
/// template specialization for std::string
template Status FileSystem::WriteValueToFile<IdType>(const IdType&,
const std::string&) const
noexcept;
template Status FileSystem::WriteValueToFile<IdType>(
const IdType&, const std::string&) const noexcept;
} // namespace graphar
6 changes: 3 additions & 3 deletions cpp/test/test_arrow_chunk_reader.cc
Original file line number Diff line number Diff line change
Expand Up @@ -465,8 +465,7 @@ TEST_CASE_METHOD(GlobalFixture, "ArrowChunkReader") {

TEST_CASE_METHOD(GlobalFixture, "JSON_TEST") {
// read file and construct graph info
std::string path =
test_data_dir + "/ldbc_sample/json/LdbcSample.graph.yml";
std::string path = test_data_dir + "/ldbc_sample/json/LdbcSample.graph.yml";
std::string src_label = "person", edge_label = "knows", dst_label = "person";
std::string vertex_property_name = "id";
std::string edge_property_name = "creationDate";
Expand Down Expand Up @@ -526,7 +525,8 @@ TEST_CASE_METHOD(GlobalFixture, "JSON_TEST") {
}

SECTION("CastDataType") {
std::string vertex_info_path = test_data_dir + "ldbc_sample/json/Person.vertex.yml";
std::string vertex_info_path =
test_data_dir + "ldbc_sample/json/Person.vertex.yml";
std::cout << "Vertex info path: " << vertex_info_path << std::endl;
auto fs = FileSystemFromUriOrPath(prefix).value();
auto yaml_content =
Expand Down

0 comments on commit 6289efc

Please sign in to comment.