-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAPREDUCE-7421. [JDK17] Upgrade Junit 4 to 5 in hadoop-mapreduce-client-jobclient Part1. #7358
base: trunk
Are you sure you want to change the base?
Conversation
💔 -1 overall
This message was automatically generated. |
…nt-jobclient Part1.
43a50e2
to
8aca0ee
Compare
💔 -1 overall
This message was automatically generated. |
…nt-jobclient Part1.
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
@cnauroth Could you please help review this PR? Thank you very much! The PR is for MAPREDUCE-7421: [JDK17] Upgrade JUnit 4 to 5 in hadoop-mapreduce-client-jobclient. Since it involves a large number of classes, I’ve split it into two PRs: Part 1: #7358 and Part 2: #7372. Part 1 has passed compilation successfully, but Part 2 depends on Part 1, so it will take some more time to complete. |
@@ -705,7 +690,7 @@ private static String unquote(String in) { | |||
* @param args | |||
* @throws Exception | |||
*/ | |||
public static void main(String[] args) throws Exception { | |||
/*public static void main(String[] args) throws Exception { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we keep this main entry point? I've never run it myself, but I wonder if someone else found it useful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for noticing this issue! I will fix it.
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
@cnauroth Can you help review this PR again? Thank you very much! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Thanks for following up on the feedback, @slfan1989 !
Description of PR
JIRA: MAPREDUCE-7421. [JDK17] Upgrade Junit 4 to 5 in hadoop-mapreduce-client-jobclient.
How was this patch tested?
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?