[ABFS][FNSOverBlob] Optimizing the current create and mkdir flow #7340

anmolanmol1234 · 2025-01-30T20:37:47Z

Optimizes the current flow for create and mkdir to reduce the number of calls.

hadoop-yetus · 2025-01-30T22:55:26Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	18m 56s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 2 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	36m 17s		trunk passed
+1 💚	compile	0m 38s		trunk passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04
+1 💚	compile	0m 33s		trunk passed with JDK Private Build-1.8.0_432-8u432-ga~~us1-0ubuntu2~~20.04-ga
+1 💚	checkstyle	0m 29s		trunk passed
+1 💚	mvnsite	0m 40s		trunk passed
+1 💚	javadoc	0m 38s		trunk passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04
+1 💚	javadoc	0m 31s		trunk passed with JDK Private Build-1.8.0_432-8u432-ga~~us1-0ubuntu2~~20.04-ga
+1 💚	spotbugs	1m 9s		trunk passed
+1 💚	shadedclient	34m 34s		branch has no errors when building and testing our client artifacts.
-0 ⚠️	patch	34m 53s		Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 30s		the patch passed
+1 💚	compile	0m 31s		the patch passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04
+1 💚	javac	0m 31s		the patch passed
+1 💚	compile	0m 28s		the patch passed with JDK Private Build-1.8.0_432-8u432-ga~~us1-0ubuntu2~~20.04-ga
+1 💚	javac	0m 28s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	0m 20s	/results-checkstyle-hadoop-tools_hadoop-azure.txt	hadoop-tools/hadoop-azure: The patch generated 8 new + 6 unchanged - 0 fixed = 14 total (was 6)
+1 💚	mvnsite	0m 31s		the patch passed
+1 💚	javadoc	0m 27s		the patch passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04
+1 💚	javadoc	0m 25s		the patch passed with JDK Private Build-1.8.0_432-8u432-ga~~us1-0ubuntu2~~20.04-ga
-1 ❌	spotbugs	1m 13s	/new-spotbugs-hadoop-tools_hadoop-azure.html	hadoop-tools/hadoop-azure generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚	shadedclient	35m 1s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	0m 36s		hadoop-azure in the patch passed.
+1 💚	asflicense	0m 36s		The patch does not generate ASF License warnings.
		136m 19s

Reason	Tests
SpotBugs	module:hadoop-tools/hadoop-azure
	Redundant nullcheck of listPathOp, which is known to be non-null in org.apache.hadoop.fs.azurebfs.services.AbfsBlobClient.createPath(String, boolean, boolean, AzureBlobFileSystemStore$Permissions, boolean, String, ContextEncryptionAdapter, TracingContext, boolean) Redundant null check at AbfsBlobClient.java:is known to be non-null in org.apache.hadoop.fs.azurebfs.services.AbfsBlobClient.createPath(String, boolean, boolean, AzureBlobFileSystemStore$Permissions, boolean, String, ContextEncryptionAdapter, TracingContext, boolean) Redundant null check at AbfsBlobClient.java:[line 431]

Subsystem	Report/Notes
Docker	ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7340/1/artifact/out/Dockerfile
GITHUB PR	#7340
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux b01539b15156 5.15.0-130-generic #140-Ubuntu SMP Wed Dec 18 17:59:53 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `3d156da`
Default Java	Private Build-1.8.0_432-8u432-ga~~us1-0ubuntu2~~20.04-ga
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_432-8u432-ga~~us1-0ubuntu2~~20.04-ga
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7340/1/testReport/
Max. process+thread count	554 (vs. ulimit of 5500)
modules	C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7340/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2025-01-30T22:55:40Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	12m 50s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 2 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	36m 40s		trunk passed
+1 💚	compile	0m 36s		trunk passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04
+1 💚	compile	0m 35s		trunk passed with JDK Private Build-1.8.0_432-8u432-ga~~us1-0ubuntu2~~20.04-ga
+1 💚	checkstyle	0m 31s		trunk passed
+1 💚	mvnsite	0m 40s		trunk passed
+1 💚	javadoc	0m 40s		trunk passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04
+1 💚	javadoc	0m 32s		trunk passed with JDK Private Build-1.8.0_432-8u432-ga~~us1-0ubuntu2~~20.04-ga
+1 💚	spotbugs	1m 11s		trunk passed
+1 💚	shadedclient	34m 28s		branch has no errors when building and testing our client artifacts.
-0 ⚠️	patch	34m 50s		Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 30s		the patch passed
+1 💚	compile	0m 30s		the patch passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04
+1 💚	javac	0m 30s		the patch passed
+1 💚	compile	0m 29s		the patch passed with JDK Private Build-1.8.0_432-8u432-ga~~us1-0ubuntu2~~20.04-ga
+1 💚	javac	0m 29s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	0m 20s	/results-checkstyle-hadoop-tools_hadoop-azure.txt	hadoop-tools/hadoop-azure: The patch generated 8 new + 6 unchanged - 0 fixed = 14 total (was 6)
+1 💚	mvnsite	0m 31s		the patch passed
+1 💚	javadoc	0m 27s		the patch passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04
+1 💚	javadoc	0m 26s		the patch passed with JDK Private Build-1.8.0_432-8u432-ga~~us1-0ubuntu2~~20.04-ga
-1 ❌	spotbugs	1m 12s	/new-spotbugs-hadoop-tools_hadoop-azure.html	hadoop-tools/hadoop-azure generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚	shadedclient	34m 54s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	0m 35s		hadoop-azure in the patch passed.
+1 💚	asflicense	0m 35s		The patch does not generate ASF License warnings.
		130m 59s

Reason	Tests
SpotBugs	module:hadoop-tools/hadoop-azure
	Redundant nullcheck of listPathOp, which is known to be non-null in org.apache.hadoop.fs.azurebfs.services.AbfsBlobClient.createPath(String, boolean, boolean, AzureBlobFileSystemStore$Permissions, boolean, String, ContextEncryptionAdapter, TracingContext, boolean) Redundant null check at AbfsBlobClient.java:is known to be non-null in org.apache.hadoop.fs.azurebfs.services.AbfsBlobClient.createPath(String, boolean, boolean, AzureBlobFileSystemStore$Permissions, boolean, String, ContextEncryptionAdapter, TracingContext, boolean) Redundant null check at AbfsBlobClient.java:[line 431]

Subsystem	Report/Notes
Docker	ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7340/2/artifact/out/Dockerfile
GITHUB PR	#7340
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 1dd9c6c3130f 5.15.0-130-generic #140-Ubuntu SMP Wed Dec 18 17:59:53 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `3d156da`
Default Java	Private Build-1.8.0_432-8u432-ga~~us1-0ubuntu2~~20.04-ga
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_432-8u432-ga~~us1-0ubuntu2~~20.04-ga
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7340/2/testReport/
Max. process+thread count	698 (vs. ulimit of 5500)
modules	C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7340/2/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2025-01-30T22:58:41Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 52s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 2 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	41m 14s		trunk passed
+1 💚	compile	0m 40s		trunk passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04
+1 💚	compile	0m 34s		trunk passed with JDK Private Build-1.8.0_432-8u432-ga~~us1-0ubuntu2~~20.04-ga
+1 💚	checkstyle	0m 30s		trunk passed
+1 💚	mvnsite	0m 40s		trunk passed
+1 💚	javadoc	0m 40s		trunk passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04
+1 💚	javadoc	0m 33s		trunk passed with JDK Private Build-1.8.0_432-8u432-ga~~us1-0ubuntu2~~20.04-ga
+1 💚	spotbugs	1m 6s		trunk passed
+1 💚	shadedclient	38m 38s		branch has no errors when building and testing our client artifacts.
-0 ⚠️	patch	38m 59s		Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 29s		the patch passed
+1 💚	compile	0m 32s		the patch passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04
+1 💚	javac	0m 31s		the patch passed
+1 💚	compile	0m 27s		the patch passed with JDK Private Build-1.8.0_432-8u432-ga~~us1-0ubuntu2~~20.04-ga
+1 💚	javac	0m 27s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	0m 19s	/results-checkstyle-hadoop-tools_hadoop-azure.txt	hadoop-tools/hadoop-azure: The patch generated 8 new + 6 unchanged - 0 fixed = 14 total (was 6)
+1 💚	mvnsite	0m 30s		the patch passed
+1 💚	javadoc	0m 28s		the patch passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04
+1 💚	javadoc	0m 25s		the patch passed with JDK Private Build-1.8.0_432-8u432-ga~~us1-0ubuntu2~~20.04-ga
-1 ❌	spotbugs	1m 8s	/new-spotbugs-hadoop-tools_hadoop-azure.html	hadoop-tools/hadoop-azure generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚	shadedclient	38m 55s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	0m 35s		hadoop-azure in the patch passed.
+1 💚	asflicense	0m 35s		The patch does not generate ASF License warnings.
		131m 10s

Reason	Tests
SpotBugs	module:hadoop-tools/hadoop-azure
	Redundant nullcheck of listPathOp, which is known to be non-null in org.apache.hadoop.fs.azurebfs.services.AbfsBlobClient.createPath(String, boolean, boolean, AzureBlobFileSystemStore$Permissions, boolean, String, ContextEncryptionAdapter, TracingContext, boolean) Redundant null check at AbfsBlobClient.java:is known to be non-null in org.apache.hadoop.fs.azurebfs.services.AbfsBlobClient.createPath(String, boolean, boolean, AzureBlobFileSystemStore$Permissions, boolean, String, ContextEncryptionAdapter, TracingContext, boolean) Redundant null check at AbfsBlobClient.java:[line 431]

Subsystem	Report/Notes
Docker	ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7340/3/artifact/out/Dockerfile
GITHUB PR	#7340
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 1e092c87551d 5.15.0-130-generic #140-Ubuntu SMP Wed Dec 18 17:59:53 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `3d156da`
Default Java	Private Build-1.8.0_432-8u432-ga~~us1-0ubuntu2~~20.04-ga
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_432-8u432-ga~~us1-0ubuntu2~~20.04-ga
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7340/3/testReport/
Max. process+thread count	583 (vs. ulimit of 5500)
modules	C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7340/3/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

anmolanmol1234 added 22 commits January 5, 2025 22:57

Ingress changes with fallback

a0164df

spotbugs and checkstyle fixes

8effcb0

spotbugs

03d51bf

revert param changes

38c412f

revert SAS changes

d487e74

javadoc fix

ffc22e6

review comments

2d60502

changes for spotbugs and checkstyle

3b3005d

inconsistent sync

e0a228a

uncomment code

b9f2f7b

Fixed SAS support for FNS Blob

0d2c693

PR review comments

1df66bb

Fix tests

51ebb13

unused code

dabcb1e

Checkstyle fix

30cd74c

Checkstyle fixes

28003f7

remove unused imports

ff6ba64

remove unused import

c1d8338

Review comments

8f1b4b7

uncomment

043cb31

Create flow optimization

0a3d699

Create optimization

8b4ea3a

github-actions bot added trunk TOOLS ABFS labels Jan 30, 2025

anmolanmol1234 added 2 commits January 30, 2025 12:42

unused imports

f19a6bb

unused imports

3d156da

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ABFS][FNSOverBlob] Optimizing the current create and mkdir flow #7340

[ABFS][FNSOverBlob] Optimizing the current create and mkdir flow #7340

anmolanmol1234 commented Jan 30, 2025

hadoop-yetus commented Jan 30, 2025

hadoop-yetus commented Jan 30, 2025

hadoop-yetus commented Jan 30, 2025

[ABFS][FNSOverBlob] Optimizing the current create and mkdir flow #7340

Are you sure you want to change the base?

[ABFS][FNSOverBlob] Optimizing the current create and mkdir flow #7340

Conversation

anmolanmol1234 commented Jan 30, 2025

hadoop-yetus commented Jan 30, 2025

hadoop-yetus commented Jan 30, 2025

hadoop-yetus commented Jan 30, 2025