Skip to content

Commit

Permalink
Changes as per comments given
Browse files Browse the repository at this point in the history
  • Loading branch information
bhattmanish98 committed Jan 30, 2025
1 parent a75744c commit c92e00a
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -330,8 +330,5 @@ public static ApiVersion getCurrentVersion() {
public static final String COPY_STATUS_ABORTED = "aborted";

Check failure on line 330 in hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/constants/AbfsHttpConstants.java

View check run for this annotation

ASF Cloudbees Jenkins ci-hadoop / Apache Yetus

hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/constants/AbfsHttpConstants.java#L330

javadoc: error: variable COPY_STATUS_ABORTED is already defined in class AbfsHttpConstants
public static final String COPY_STATUS_FAILED = "failed";

Check failure on line 331 in hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/constants/AbfsHttpConstants.java

View check run for this annotation

ASF Cloudbees Jenkins ci-hadoop / Apache Yetus

hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/constants/AbfsHttpConstants.java#L331

javadoc: error: variable COPY_STATUS_FAILED is already defined in class AbfsHttpConstants

public static final String ATOMIC_DIR_RENAME_RECOVERY_ON_GET_PATH_EXCEPTION =
"Path had to be recovered from atomic rename operation.";

private AbfsHttpConstants() {}
}
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,23 @@ public void testCreateOnRoot() throws Exception {
}
}

@Test
public void testCreateNonRecursiveWhenParentNotExist() throws Exception {
AzureBlobFileSystem fs = getFileSystem();
Path createDirectoryPath = path("A/");
fs.mkdirs(createDirectoryPath);
fs.createNonRecursive(path("A/B/C"), FsPermission
.getDefault(), false, 1024, (short) 1, 1024, null).close();

// ex = intercept(AbfsRestOperationException.class, () ->
// fs.createNonRecursive(testFile, FsPermission.getDefault(),
// false, 1024, (short) 1, 1024, null));
// if (ex.getStatusCode() != HTTP_CONFLICT) {
// // Request should fail with 409.
// throw ex;
// }
}

/**
* Attempts to use to the ABFS stream after it is closed.
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -452,6 +452,7 @@ public static AbfsClient getMockAbfsClient(AbfsClient baseAbfsClientInstance,
(currentAuthType == AuthType.SharedKey)
|| (currentAuthType == AuthType.OAuth));

// TODO : [FnsOverBlob][HADOOP-19234] Update to work with Blob Endpoint as well when Fns Over Blob is ready.
AbfsClient client = mock(AbfsDfsClient.class);
AbfsPerfTracker tracker = new AbfsPerfTracker(
"test",
Expand Down

0 comments on commit c92e00a

Please sign in to comment.