-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[style](properties)(log) Optimize invalid property alert words #47933
Open
chuang-wang-pre
wants to merge
2
commits into
apache:master
Choose a base branch
from
chuang-wang-pre:feat/invalid_property_exception_msg
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[style](properties)(log) Optimize invalid property alert words #47933
chuang-wang-pre
wants to merge
2
commits into
apache:master
from
chuang-wang-pre:feat/invalid_property_exception_msg
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
run buildall |
TPC-H: Total hot run time: 31495 ms
|
TPC-DS: Total hot run time: 189713 ms
|
ClickBench: Total hot run time: 30.17 s
|
07805d3
to
e69ca71
Compare
run buildall |
TPC-H: Total hot run time: 31359 ms
|
TPC-DS: Total hot run time: 189862 ms
|
ClickBench: Total hot run time: 30.3 s
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
When executing SQL statements with properties, if some properties are based on valid keys with spaces, the returned exception information may be misleading.
For example, this alter statement
alter table test_dynamic_partition set ( "dynamic_partition.start " = "-2");
[dynamic_partition.start]
is a valid property, but the user may have typed an extra spaceDoris returned the following result:
errCode = 2, detailMessage = Invalid dynamic partition properties: dynamic_partition.start
Users may find it difficult to identify the issue from the returned information and may consider it a bug
Optimized return information:
errCode = 2, detailMessage = Invalid dynamic partition properties: [dynamic_partition.start ]
If multiple properties are illegal, they will be returned:
errCode = 2, detailMessage = Invalid dynamic partition properties: [dynamic_partition.start ], [dynamic_partition.edn]
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)