Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement](recycler) Add valid s3 vault config for recycler #47723

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Yukang-Lian
Copy link
Collaborator

@Yukang-Lian Yukang-Lian commented Feb 10, 2025

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

In the current multi-vault mode, deleting vaults is not allowed. This causes the recycler to still attempt accessing invalid vaults when deleting data, slowing down the deletion process. The HDFS accessor automatically checks the connectivity of vaults during initialization and only initializes connected HDFS vaults. However, S3 does not check if vaults are connected and initializes all vaults, including invalid ones. This PR adds a configuration that allows users to specify valid S3 vaults. If configured, only the endpoints listed in this vector will be initialized when initializing S3 vaults.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Yukang-Lian
Copy link
Collaborator Author

run buildall

@doris-robot
Copy link

TeamCity cloud ut coverage result:
Function Coverage: 82.33% (1062/1290)
Line Coverage: 65.85% (17552/26654)
Region Coverage: 65.35% (8658/13249)
Branch Coverage: 55.23% (4667/8450)
Coverage Report: http://coverage.selectdb-in.cc/coverage/5bb603faeb9a6dbfb07b9aec23b66c051aaae241_5bb603faeb9a6dbfb07b9aec23b66c051aaae241_cloud/report/index.html

@Yukang-Lian Yukang-Lian force-pushed the Add-Config-For-Valid-S3-Valut branch from 5bb603f to e2309c4 Compare February 12, 2025 04:14
@Yukang-Lian
Copy link
Collaborator Author

run buildall

@doris-robot
Copy link

TeamCity cloud ut coverage result:
Function Coverage: 82.40% (1063/1290)
Line Coverage: 66.02% (17599/26658)
Region Coverage: 65.43% (8670/13250)
Branch Coverage: 55.30% (4673/8450)
Coverage Report: http://coverage.selectdb-in.cc/coverage/e2309c4831a79b58f675588bd375d16c4bdeb075_e2309c4831a79b58f675588bd375d16c4bdeb075_cloud/report/index.html

Copy link
Contributor

@gavinchou gavinchou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

request change

@Yukang-Lian
Copy link
Collaborator Author

run buildall

@Yukang-Lian
Copy link
Collaborator Author

run buildall

@doris-robot
Copy link

TeamCity cloud ut coverage result:
Function Coverage: 82.40% (1063/1290)
Line Coverage: 66.09% (17618/26659)
Region Coverage: 65.54% (8684/13250)
Branch Coverage: 55.42% (4683/8450)
Coverage Report: http://coverage.selectdb-in.cc/coverage/abf1e5a1dd23e582843305ca4922952f240b25a4_abf1e5a1dd23e582843305ca4922952f240b25a4_cloud/report/index.html

@Yukang-Lian
Copy link
Collaborator Author

run cloud_p0

@Yukang-Lian
Copy link
Collaborator Author

run buildall

@doris-robot
Copy link

TeamCity cloud ut coverage result:
Function Coverage: 82.28% (1063/1292)
Line Coverage: 65.86% (17600/26723)
Region Coverage: 65.37% (8674/13270)
Branch Coverage: 55.28% (4677/8460)
Coverage Report: http://coverage.selectdb-in.cc/coverage/c17c494ac5cb5f49cb1a2d8e02dd09319729678b_c17c494ac5cb5f49cb1a2d8e02dd09319729678b_cloud/report/index.html

@Yukang-Lian
Copy link
Collaborator Author

run cloud_p0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants