-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](mv) Fix sync mv add default select limit wrongly #47717
Open
seawinde
wants to merge
5
commits into
apache:master
Choose a base branch
from
seawinde:fix_sync_mv_add_default_limit_wrongly
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[fix](mv) Fix sync mv add default select limit wrongly #47717
seawinde
wants to merge
5
commits into
apache:master
from
seawinde:fix_sync_mv_add_default_limit_wrongly
+346
−142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
run buildall |
run buildall |
morrySnow
previously approved these changes
Feb 11, 2025
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
TPC-H: Total hot run time: 31303 ms
|
TPC-DS: Total hot run time: 191211 ms
|
ClickBench: Total hot run time: 31.19 s
|
run buildall |
TPC-H: Total hot run time: 31412 ms
|
TPC-DS: Total hot run time: 189738 ms
|
ClickBench: Total hot run time: 30.4 s
|
run buildall |
TPC-H: Total hot run time: 31544 ms
|
TPC-DS: Total hot run time: 184043 ms
|
ClickBench: Total hot run time: 30.92 s
|
run buildall |
TPC-H: Total hot run time: 31441 ms
|
TPC-DS: Total hot run time: 190693 ms
|
ClickBench: Total hot run time: 30.25 s
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
mv def is as follwoing:
if we
set sql_select_limit = 1;
the query as following should rewrite successfully, but now fail, the pr fix this
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
Fix sync mv add default select limit wrongly
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)