Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[branch-2.0] fix select * from variables system table (#34529) #47674

Open
wants to merge 1 commit into
base: branch-2.0
Choose a base branch
from

Conversation

wangbo
Copy link
Contributor

@wangbo wangbo commented Feb 10, 2025

pick #34529

after apache#23017, information_schema.session_variables and information_schema.global_variables had 2 new columns, but
SchemaVariablesScanner just 2 columns. when select * from *_variables, will get 'no match column for this column' error

Signed-off-by: nextdreamblue <[email protected]>
@wangbo
Copy link
Contributor Author

wangbo commented Feb 10, 2025

run buildall

@Thearas
Copy link
Contributor

Thearas commented Feb 10, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@doris-robot
Copy link

TPC-H: Total hot run time: 49916 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 3a3a8456f1badb49e173aeaa35211bf54bce0297, data reload: false

------ Round 1 ----------------------------------
q1	17532	4422	4391	4391
q2	2063	158	154	154
q3	10254	1900	1925	1900
q4	10114	1287	1345	1287
q5	8439	3930	3973	3930
q6	239	126	126	126
q7	2059	1618	1629	1618
q8	9297	2757	2735	2735
q9	10547	10547	10377	10377
q10	8660	3540	3594	3540
q11	410	246	241	241
q12	469	298	301	298
q13	18375	3969	4048	3969
q14	345	326	326	326
q15	517	462	466	462
q16	548	461	464	461
q17	1147	989	984	984
q18	7340	6929	6830	6830
q19	1679	1550	1542	1542
q20	547	299	293	293
q21	4438	4170	4056	4056
q22	506	396	404	396
Total cold run time: 115525 ms
Total hot run time: 49916 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4374	4322	4320	4320
q2	323	231	223	223
q3	4172	4151	4148	4148
q4	2756	2761	2770	2761
q5	7326	7163	7183	7163
q6	238	122	121	121
q7	3275	2816	2873	2816
q8	4419	4499	4523	4499
q9	14346	14073	13932	13932
q10	4226	4295	4315	4295
q11	751	684	677	677
q12	1033	817	890	817
q13	6847	3740	3719	3719
q14	448	425	431	425
q15	504	459	462	459
q16	641	612	594	594
q17	3877	3845	3872	3845
q18	8841	8757	9004	8757
q19	1719	1687	1713	1687
q20	2389	2151	2141	2141
q21	8511	8438	8480	8438
q22	1022	949	959	949
Total cold run time: 82038 ms
Total hot run time: 76786 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 215847 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 3a3a8456f1badb49e173aeaa35211bf54bce0297, data reload: false

query1	962	397	385	385
query2	6537	2125	2046	2046
query3	6919	205	206	205
query4	23149	21816	22239	21816
query5	19738	6567	6496	6496
query6	289	226	244	226
query7	4341	305	304	304
query8	259	266	255	255
query9	3113	2675	2600	2600
query10	481	313	307	307
query11	15670	14854	15404	14854
query12	137	77	73	73
query13	1037	453	462	453
query14	17334	13712	13618	13618
query15	372	217	229	217
query16	6488	285	265	265
query17	1767	953	918	918
query18	893	323	321	321
query19	213	154	149	149
query20	106	96	98	96
query21	192	97	98	97
query22	5348	5023	4960	4960
query23	34326	33509	33496	33496
query24	6981	6309	6286	6286
query25	525	439	430	430
query26	811	162	165	162
query27	2309	298	294	294
query28	6094	2302	2255	2255
query29	2939	2807	2789	2789
query30	245	176	172	172
query31	986	731	720	720
query32	74	61	63	61
query33	440	269	262	262
query34	876	479	477	477
query35	1147	909	927	909
query36	1302	1139	1216	1139
query37	92	61	62	61
query38	3159	2955	2916	2916
query39	1380	1337	1314	1314
query40	221	97	97	97
query41	43	37	38	37
query42	82	87	80	80
query43	616	581	577	577
query44	1188	715	726	715
query45	247	229	232	229
query46	1247	949	944	944
query47	1924	1681	1815	1681
query48	504	426	403	403
query49	616	368	398	368
query50	849	589	632	589
query51	4821	4703	4736	4703
query52	93	80	75	75
query53	227	184	191	184
query54	2685	2479	2463	2463
query55	101	85	90	85
query56	229	212	190	190
query57	1249	1148	1125	1125
query58	228	228	225	225
query59	3555	3350	3119	3119
query60	223	213	199	199
query61	98	96	97	96
query62	836	481	423	423
query63	198	184	173	173
query64	3298	1551	1490	1490
query65	3634	3566	3553	3553
query66	784	415	408	408
query67	15562	16827	17052	16827
query68	9112	641	650	641
query69	494	280	277	277
query70	1573	1460	1316	1316
query71	395	308	321	308
query72	6816	4836	4920	4836
query73	764	316	325	316
query74	6276	5867	5858	5858
query75	4572	3769	3706	3706
query76	4705	1098	1117	1098
query77	649	251	264	251
query78	12758	12983	13650	12983
query79	12209	629	635	629
query80	800	413	399	399
query81	497	232	239	232
query82	683	99	91	91
query83	193	133	131	131
query84	256	71	72	71
query85	730	323	319	319
query86	330	293	276	276
query87	3309	3091	3060	3060
query88	5231	2286	2327	2286
query89	416	309	303	303
query90	2115	217	212	212
query91	165	129	138	129
query92	60	52	51	51
query93	5175	606	597	597
query94	944	211	210	210
query95	2050	1980	2056	1980
query96	645	325	340	325
query97	6569	6403	6511	6403
query98	230	214	210	210
query99	2805	881	958	881
Total cold run time: 317915 ms
Total hot run time: 215847 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.2 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 3a3a8456f1badb49e173aeaa35211bf54bce0297, data reload: false

query1	0.03	0.03	0.02
query2	0.07	0.03	0.02
query3	0.24	0.04	0.04
query4	1.80	0.07	0.06
query5	0.53	0.53	0.53
query6	1.23	0.61	0.61
query7	0.02	0.01	0.01
query8	0.04	0.02	0.02
query9	0.52	0.49	0.47
query10	0.53	0.53	0.53
query11	0.13	0.09	0.10
query12	0.12	0.09	0.09
query13	0.61	0.61	0.61
query14	0.78	0.79	0.79
query15	0.79	0.77	0.78
query16	0.36	0.36	0.38
query17	1.01	1.01	0.99
query18	0.21	0.26	0.24
query19	1.86	1.89	1.81
query20	0.02	0.00	0.01
query21	15.44	0.57	0.56
query22	2.23	2.01	1.76
query23	16.29	1.05	0.95
query24	6.21	1.23	1.76
query25	0.36	0.09	0.06
query26	0.75	0.16	0.16
query27	0.05	0.03	0.04
query28	6.29	0.78	0.75
query29	12.64	2.26	2.33
query30	0.62	0.51	0.51
query31	2.82	0.38	0.37
query32	3.36	0.49	0.49
query33	3.14	3.09	3.07
query34	15.26	4.83	4.82
query35	4.88	4.86	4.87
query36	1.06	1.01	1.01
query37	0.06	0.05	0.04
query38	0.03	0.02	0.02
query39	0.02	0.01	0.02
query40	0.16	0.15	0.14
query41	0.07	0.01	0.01
query42	0.02	0.02	0.02
query43	0.02	0.01	0.02
Total cold run time: 102.68 s
Total hot run time: 31.2 s

@doris-robot
Copy link

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit 3a3a8456f1badb49e173aeaa35211bf54bce0297 with default session variables
Stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select:       22.1 seconds inserted 10000000 Rows, about 452K ops/s

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.56% (8312/21555)
Line Coverage: 30.26% (68757/227236)
Region Coverage: 29.68% (35405/119282)
Branch Coverage: 25.44% (18197/71534)
Coverage Report: http://coverage.selectdb-in.cc/coverage/3a3a8456f1badb49e173aeaa35211bf54bce0297_3a3a8456f1badb49e173aeaa35211bf54bce0297/report/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants