Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](nereids) Create Runtime filter even if equal.right is not in aliasTransferMap #46406

Merged
merged 3 commits into from
Jan 6, 2025

Conversation

englefly
Copy link
Contributor

@englefly englefly commented Jan 3, 2025

What problem does this PR solve?

fix a bug introduced by #40815
Issue Number: close #xxx

Related PR: #40815

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@englefly
Copy link
Contributor Author

englefly commented Jan 3, 2025

run buildall

@englefly
Copy link
Contributor Author

englefly commented Jan 3, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32523 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 2d9f03ffc56d3edaa17396788ded5e3e9a3adc2b, data reload: false

------ Round 1 ----------------------------------
q1	17570	6144	6019	6019
q2	2048	301	166	166
q3	10429	1254	739	739
q4	10231	856	425	425
q5	7735	2174	1961	1961
q6	211	185	147	147
q7	896	776	600	600
q8	9239	1351	1135	1135
q9	5159	4895	4922	4895
q10	6751	2297	1867	1867
q11	502	280	252	252
q12	353	352	222	222
q13	17783	3594	3126	3126
q14	239	230	217	217
q15	573	510	501	501
q16	631	612	589	589
q17	575	837	325	325
q18	6842	6367	6376	6367
q19	1850	961	541	541
q20	307	313	181	181
q21	2946	2225	1952	1952
q22	352	331	296	296
Total cold run time: 103222 ms
Total hot run time: 32523 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6290	6247	6254	6247
q2	231	326	229	229
q3	2296	2651	2267	2267
q4	1402	1818	1332	1332
q5	4377	4775	4729	4729
q6	183	179	148	148
q7	2074	1958	1833	1833
q8	2623	2885	2698	2698
q9	7270	7253	7319	7253
q10	3076	3366	2890	2890
q11	580	494	479	479
q12	656	725	606	606
q13	3571	3858	3288	3288
q14	294	314	287	287
q15	585	526	502	502
q16	652	700	652	652
q17	1230	1707	1239	1239
q18	7690	7493	7348	7348
q19	865	1197	1166	1166
q20	1971	2032	1934	1934
q21	5698	5244	4947	4947
q22	635	639	578	578
Total cold run time: 54249 ms
Total hot run time: 52652 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 197095 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 2d9f03ffc56d3edaa17396788ded5e3e9a3adc2b, data reload: false

query1	1327	935	900	900
query2	6149	2325	2303	2303
query3	10984	4714	4638	4638
query4	33598	23686	23420	23420
query5	5142	622	452	452
query6	303	206	202	202
query7	3999	488	293	293
query8	315	273	242	242
query9	9463	2634	2637	2634
query10	523	307	251	251
query11	18162	15380	15245	15245
query12	164	107	109	107
query13	1714	540	412	412
query14	11753	7663	7426	7426
query15	242	216	197	197
query16	8060	653	486	486
query17	1499	787	625	625
query18	2130	405	304	304
query19	198	195	166	166
query20	121	113	109	109
query21	198	161	120	120
query22	4772	4772	4624	4624
query23	34365	33396	33584	33396
query24	6071	2301	2316	2301
query25	481	463	404	404
query26	717	279	148	148
query27	2156	470	327	327
query28	5551	2478	2411	2411
query29	631	552	429	429
query30	214	182	150	150
query31	987	928	907	907
query32	77	58	60	58
query33	482	356	324	324
query34	772	854	514	514
query35	821	850	777	777
query36	1043	1036	968	968
query37	114	105	76	76
query38	4197	4217	4110	4110
query39	1540	1477	1454	1454
query40	210	119	101	101
query41	45	43	45	43
query42	119	100	97	97
query43	524	530	499	499
query44	1309	818	811	811
query45	186	180	165	165
query46	886	1065	658	658
query47	2026	1988	1929	1929
query48	389	419	340	340
query49	714	504	419	419
query50	679	677	398	398
query51	7442	7212	7207	7207
query52	104	94	97	94
query53	227	262	194	194
query54	487	492	411	411
query55	85	79	80	79
query56	277	259	277	259
query57	1246	1245	1198	1198
query58	250	230	219	219
query59	3088	3370	3203	3203
query60	277	284	258	258
query61	112	104	108	104
query62	841	836	768	768
query63	229	195	184	184
query64	3163	1041	647	647
query65	3328	3282	3265	3265
query66	776	408	317	317
query67	16437	15962	15572	15572
query68	8800	710	513	513
query69	495	282	286	282
query70	1171	1145	1152	1145
query71	447	283	254	254
query72	6339	3822	3840	3822
query73	640	768	355	355
query74	10197	9144	9043	9043
query75	4157	3159	2677	2677
query76	3704	1199	780	780
query77	807	376	269	269
query78	10318	10115	9440	9440
query79	3753	796	574	574
query80	725	510	443	443
query81	506	263	230	230
query82	669	150	128	128
query83	158	161	150	150
query84	241	89	70	70
query85	782	350	305	305
query86	379	321	307	307
query87	4618	4590	4372	4372
query88	4615	2146	2147	2146
query89	427	334	289	289
query90	1818	185	183	183
query91	131	144	105	105
query92	71	56	54	54
query93	2545	862	540	540
query94	637	402	292	292
query95	333	272	247	247
query96	492	615	273	273
query97	2881	2969	2817	2817
query98	225	193	209	193
query99	1711	1589	1448	1448
Total cold run time: 301283 ms
Total hot run time: 197095 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.94 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 2d9f03ffc56d3edaa17396788ded5e3e9a3adc2b, data reload: false

query1	0.03	0.04	0.03
query2	0.07	0.03	0.03
query3	0.24	0.07	0.07
query4	1.62	0.10	0.10
query5	0.40	0.44	0.40
query6	1.14	0.66	0.64
query7	0.02	0.02	0.02
query8	0.04	0.03	0.03
query9	0.60	0.49	0.52
query10	0.56	0.55	0.54
query11	0.14	0.10	0.11
query12	0.14	0.10	0.11
query13	0.60	0.61	0.59
query14	2.76	2.80	2.75
query15	0.90	0.82	0.83
query16	0.39	0.39	0.37
query17	1.05	1.01	1.04
query18	0.23	0.20	0.20
query19	1.92	1.78	2.03
query20	0.01	0.01	0.01
query21	15.36	0.91	0.59
query22	0.77	0.85	0.85
query23	14.99	1.41	0.53
query24	2.60	1.41	0.70
query25	0.18	0.26	0.05
query26	0.21	0.15	0.13
query27	0.08	0.04	0.04
query28	13.55	1.58	1.04
query29	12.59	3.96	3.25
query30	0.25	0.09	0.06
query31	2.82	0.61	0.37
query32	3.23	0.53	0.46
query33	3.01	3.06	3.18
query34	16.66	5.21	4.48
query35	4.48	4.44	4.49
query36	0.64	0.53	0.49
query37	0.10	0.06	0.06
query38	0.05	0.04	0.04
query39	0.03	0.02	0.02
query40	0.18	0.14	0.13
query41	0.08	0.03	0.02
query42	0.03	0.03	0.02
query43	0.04	0.03	0.03
Total cold run time: 104.79 s
Total hot run time: 30.94 s

englefly added a commit that referenced this pull request Jan 4, 2025
…iasTransferMap-branch3.0 (#46224)

### What problem does this PR solve?

Issue Number: close #xxx
pick #46406
Related PR: #40815
englefly added a commit that referenced this pull request Jan 4, 2025
…iasTransferMap (branch-2.1) (#46407)

### What problem does this PR solve?

pick #46406
Related PR: #40815
@englefly
Copy link
Contributor Author

englefly commented Jan 4, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32467 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 99f4c7e091f5713916cebb2644fb8fc68f7160bd, data reload: false

------ Round 1 ----------------------------------
q1	17611	6729	6025	6025
q2	2055	291	162	162
q3	10438	1242	704	704
q4	10220	852	438	438
q5	7504	2163	1931	1931
q6	206	180	149	149
q7	891	719	598	598
q8	9239	1308	1136	1136
q9	5111	4910	4973	4910
q10	6754	2312	1847	1847
q11	492	274	264	264
q12	351	365	229	229
q13	17792	3625	3075	3075
q14	232	231	215	215
q15	567	505	506	505
q16	631	632	591	591
q17	553	838	331	331
q18	7274	6434	6358	6358
q19	1232	977	544	544
q20	309	311	200	200
q21	2735	2137	1941	1941
q22	357	323	314	314
Total cold run time: 102554 ms
Total hot run time: 32467 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6232	6185	6361	6185
q2	233	328	232	232
q3	2255	2623	2335	2335
q4	1360	1811	1347	1347
q5	4335	4751	4730	4730
q6	193	177	140	140
q7	2085	1991	1827	1827
q8	2569	2813	2661	2661
q9	7290	7186	7174	7174
q10	3035	3317	2818	2818
q11	572	516	496	496
q12	672	761	589	589
q13	3453	3789	3193	3193
q14	295	328	281	281
q15	550	505	494	494
q16	619	680	667	667
q17	1194	1732	1262	1262
q18	7675	7556	7278	7278
q19	833	1001	1089	1001
q20	1930	1996	1832	1832
q21	5362	4919	4791	4791
q22	624	618	592	592
Total cold run time: 53366 ms
Total hot run time: 51925 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 191884 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 99f4c7e091f5713916cebb2644fb8fc68f7160bd, data reload: false

query1	971	394	370	370
query2	6514	2307	2203	2203
query3	6703	215	210	210
query4	33908	23683	24035	23683
query5	4290	628	471	471
query6	288	202	190	190
query7	4625	505	308	308
query8	322	246	236	236
query9	9539	2633	2644	2633
query10	470	318	270	270
query11	18014	15352	15105	15105
query12	160	116	105	105
query13	1678	557	433	433
query14	10025	6928	6779	6779
query15	244	204	199	199
query16	8381	577	450	450
query17	1590	746	575	575
query18	2147	433	287	287
query19	204	181	157	157
query20	117	108	106	106
query21	206	119	137	119
query22	4397	4480	4244	4244
query23	34885	33787	33848	33787
query24	6638	2351	2301	2301
query25	454	460	388	388
query26	1103	281	153	153
query27	2072	473	342	342
query28	5242	2407	2403	2403
query29	541	545	415	415
query30	226	181	149	149
query31	988	895	814	814
query32	96	63	60	60
query33	500	352	292	292
query34	774	831	510	510
query35	789	818	722	722
query36	1028	1035	974	974
query37	116	103	79	79
query38	4156	4270	4097	4097
query39	1503	1438	1447	1438
query40	198	118	102	102
query41	45	43	46	43
query42	132	104	106	104
query43	517	541	506	506
query44	1360	809	796	796
query45	188	176	169	169
query46	874	1052	674	674
query47	1926	1913	1874	1874
query48	384	408	317	317
query49	781	475	395	395
query50	657	648	383	383
query51	7270	7125	7120	7120
query52	102	104	96	96
query53	234	267	195	195
query54	473	491	404	404
query55	82	89	89	89
query56	277	272	234	234
query57	1181	1194	1117	1117
query58	240	224	248	224
query59	3059	3117	2982	2982
query60	270	269	250	250
query61	137	119	114	114
query62	839	811	737	737
query63	236	205	203	203
query64	4598	997	644	644
query65	3349	3188	3231	3188
query66	1064	422	308	308
query67	16159	16563	15834	15834
query68	8924	705	533	533
query69	467	324	315	315
query70	1246	1046	1134	1046
query71	449	288	256	256
query72	6227	3730	3869	3730
query73	661	766	358	358
query74	9846	9310	9331	9310
query75	4472	3290	2650	2650
query76	3974	1205	799	799
query77	781	368	271	271
query78	10170	10212	11429	10212
query79	2735	762	602	602
query80	638	580	438	438
query81	458	280	233	233
query82	222	141	133	133
query83	208	176	142	142
query84	276	90	72	72
query85	799	383	312	312
query86	355	316	306	306
query87	4570	4398	4403	4398
query88	3472	2180	2140	2140
query89	402	315	297	297
query90	1918	189	190	189
query91	139	134	116	116
query92	65	56	55	55
query93	959	802	527	527
query94	667	400	293	293
query95	342	266	248	248
query96	496	610	280	280
query97	2936	2906	2823	2823
query98	232	207	202	202
query99	1761	1539	1439	1439
Total cold run time: 293403 ms
Total hot run time: 191884 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.36 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 99f4c7e091f5713916cebb2644fb8fc68f7160bd, data reload: false

query1	0.04	0.03	0.03
query2	0.06	0.04	0.03
query3	0.25	0.06	0.07
query4	1.61	0.10	0.10
query5	0.42	0.40	0.40
query6	1.15	0.66	0.66
query7	0.02	0.01	0.01
query8	0.04	0.03	0.03
query9	0.59	0.50	0.50
query10	0.55	0.57	0.54
query11	0.14	0.10	0.11
query12	0.14	0.11	0.12
query13	0.60	0.61	0.60
query14	2.74	2.77	2.74
query15	0.91	0.81	0.81
query16	0.37	0.38	0.38
query17	1.05	0.99	1.06
query18	0.23	0.22	0.21
query19	1.85	1.82	1.96
query20	0.01	0.01	0.01
query21	15.35	0.95	0.56
query22	0.76	0.78	0.62
query23	15.35	1.34	0.51
query24	3.51	1.18	1.25
query25	0.17	0.13	0.13
query26	0.30	0.14	0.13
query27	0.05	0.08	0.06
query28	14.25	1.50	1.04
query29	12.61	3.98	3.22
query30	0.24	0.08	0.07
query31	2.83	0.61	0.38
query32	3.22	0.55	0.46
query33	3.20	3.14	3.18
query34	16.64	5.15	4.47
query35	4.50	4.48	4.50
query36	0.85	0.48	0.49
query37	0.09	0.06	0.05
query38	0.04	0.03	0.03
query39	0.04	0.02	0.03
query40	0.17	0.14	0.13
query41	0.08	0.02	0.02
query42	0.04	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 107.09 s
Total hot run time: 31.36 s

@englefly
Copy link
Contributor Author

englefly commented Jan 4, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32918 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit b944ffdf21515e003bc9b6f96051b5680deb406f, data reload: false

------ Round 1 ----------------------------------
q1	17572	6138	6058	6058
q2	2047	306	172	172
q3	10406	1233	731	731
q4	10214	855	432	432
q5	7522	2167	1976	1976
q6	207	181	145	145
q7	880	739	605	605
q8	9240	1360	1194	1194
q9	5276	4864	4961	4864
q10	6756	2281	1879	1879
q11	477	289	254	254
q12	359	365	223	223
q13	18063	3847	3255	3255
q14	248	252	230	230
q15	558	515	505	505
q16	641	603	593	593
q17	590	851	338	338
q18	7066	6665	6431	6431
q19	4046	976	530	530
q20	302	308	182	182
q21	2875	2193	2015	2015
q22	361	349	306	306
Total cold run time: 105706 ms
Total hot run time: 32918 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6408	6232	6243	6232
q2	241	335	234	234
q3	2256	2641	2339	2339
q4	1357	1802	1385	1385
q5	4343	4770	4904	4770
q6	186	177	138	138
q7	2137	1981	1866	1866
q8	2671	2821	2681	2681
q9	7191	7300	7307	7300
q10	3117	3315	2772	2772
q11	579	534	505	505
q12	681	768	655	655
q13	3510	3943	3289	3289
q14	285	312	270	270
q15	577	520	497	497
q16	662	707	637	637
q17	1209	1716	1280	1280
q18	7752	7574	7347	7347
q19	852	1183	1073	1073
q20	2008	2051	1890	1890
q21	5722	5059	5019	5019
q22	612	650	587	587
Total cold run time: 54356 ms
Total hot run time: 52766 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 197579 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit b944ffdf21515e003bc9b6f96051b5680deb406f, data reload: false

query1	1291	985	925	925
query2	6518	2423	2311	2311
query3	10994	4630	4555	4555
query4	32810	23761	23540	23540
query5	4293	615	447	447
query6	286	208	192	192
query7	3983	485	304	304
query8	316	247	234	234
query9	9485	2623	2600	2600
query10	465	327	250	250
query11	18419	15425	15211	15211
query12	169	108	103	103
query13	1594	540	413	413
query14	10645	7489	7455	7455
query15	263	213	184	184
query16	8068	669	471	471
query17	1561	781	618	618
query18	2195	444	359	359
query19	199	194	163	163
query20	118	122	110	110
query21	209	120	109	109
query22	4919	4652	4509	4509
query23	34273	34210	33839	33839
query24	6187	2262	2281	2262
query25	476	471	388	388
query26	718	282	149	149
query27	2192	463	340	340
query28	5359	2429	2411	2411
query29	682	582	422	422
query30	219	183	148	148
query31	964	910	824	824
query32	88	63	55	55
query33	509	351	296	296
query34	757	854	508	508
query35	793	862	753	753
query36	1056	1062	990	990
query37	118	100	71	71
query38	4209	4212	4179	4179
query39	1564	1490	1458	1458
query40	198	115	108	108
query41	47	43	44	43
query42	117	99	105	99
query43	525	518	498	498
query44	1367	825	809	809
query45	181	187	168	168
query46	888	1065	678	678
query47	2017	2036	1994	1994
query48	394	400	319	319
query49	741	499	404	404
query50	644	671	387	387
query51	7243	7202	7230	7202
query52	100	101	96	96
query53	237	258	183	183
query54	469	475	418	418
query55	78	82	84	82
query56	258	248	242	242
query57	1282	1277	1144	1144
query58	234	232	230	230
query59	3330	3371	3234	3234
query60	279	263	267	263
query61	116	107	110	107
query62	835	822	749	749
query63	236	207	200	200
query64	3333	1054	651	651
query65	3340	3267	3248	3248
query66	690	421	300	300
query67	16425	15988	15681	15681
query68	9526	712	512	512
query69	477	302	249	249
query70	1282	1120	1136	1120
query71	437	277	259	259
query72	6565	3804	3888	3804
query73	648	754	358	358
query74	9868	9059	9243	9059
query75	4491	3165	2688	2688
query76	4001	1192	812	812
query77	777	370	316	316
query78	10200	10197	9506	9506
query79	3433	790	578	578
query80	578	508	430	430
query81	506	269	231	231
query82	668	152	119	119
query83	161	159	141	141
query84	248	90	74	74
query85	798	358	306	306
query86	406	315	305	305
query87	4433	4632	4417	4417
query88	4503	2155	2175	2155
query89	427	336	305	305
query90	1708	187	187	187
query91	130	141	105	105
query92	67	59	51	51
query93	1992	900	541	541
query94	629	368	285	285
query95	332	255	246	246
query96	490	606	274	274
query97	2903	3011	2812	2812
query98	223	198	194	194
query99	1663	1555	1447	1447
Total cold run time: 299138 ms
Total hot run time: 197579 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.96 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit b944ffdf21515e003bc9b6f96051b5680deb406f, data reload: false

query1	0.03	0.04	0.04
query2	0.07	0.04	0.03
query3	0.24	0.06	0.07
query4	1.61	0.10	0.10
query5	0.42	0.43	0.41
query6	1.17	0.66	0.65
query7	0.02	0.02	0.01
query8	0.04	0.03	0.03
query9	0.59	0.52	0.50
query10	0.56	0.56	0.56
query11	0.15	0.10	0.11
query12	0.14	0.11	0.11
query13	0.61	0.60	0.61
query14	2.71	2.86	2.68
query15	0.88	0.83	0.81
query16	0.36	0.37	0.38
query17	1.06	1.06	1.06
query18	0.23	0.21	0.20
query19	1.98	1.86	2.01
query20	0.02	0.01	0.01
query21	15.35	0.91	0.57
query22	0.76	0.75	0.75
query23	15.25	1.48	0.59
query24	2.94	1.60	0.65
query25	0.24	0.20	0.11
query26	0.34	0.14	0.13
query27	0.07	0.04	0.06
query28	13.51	1.50	1.04
query29	12.59	3.96	3.26
query30	0.24	0.10	0.06
query31	2.84	0.58	0.37
query32	3.23	0.54	0.45
query33	3.27	3.11	3.06
query34	16.64	5.12	4.48
query35	4.47	4.44	4.46
query36	0.83	0.47	0.48
query37	0.09	0.06	0.06
query38	0.05	0.03	0.04
query39	0.04	0.02	0.02
query40	0.17	0.13	0.12
query41	0.07	0.02	0.03
query42	0.04	0.02	0.02
query43	0.03	0.04	0.03
Total cold run time: 105.95 s
Total hot run time: 30.96 s

@wm1581066 wm1581066 added the usercase Important user case type label label Jan 4, 2025
@englefly
Copy link
Contributor Author

englefly commented Jan 4, 2025

run p0

1 similar comment
@englefly
Copy link
Contributor Author

englefly commented Jan 5, 2025

run p0

Copy link
Contributor

github-actions bot commented Jan 6, 2025

PR approved by anyone and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 6, 2025
Copy link
Contributor

github-actions bot commented Jan 6, 2025

PR approved by at least one committer and no changes requested.

@englefly englefly merged commit a539e22 into apache:master Jan 6, 2025
25 of 27 checks passed
@englefly englefly deleted the rf-agg-missing branch January 6, 2025 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.8-merged dev/3.0.4-merged reviewed usercase Important user case type label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants