Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](regression) spare .testfile to make disk checker happy when injecting fault #30012

Merged
merged 1 commit into from
Jan 16, 2024
Merged

[fix](regression) spare .testfile to make disk checker happy when injecting fault #30012

merged 1 commit into from
Jan 16, 2024

Conversation

liaoxin01
Copy link
Contributor

@liaoxin01 liaoxin01 commented Jan 16, 2024 •
edited
Loading

Proposed changes

Issue Number: close #xxx

Supplement to #29477

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

@liaoxin01
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 40242 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 86b787e0b36b737cf917e0cf01b00269bd70848e, data reload: false

------ Round 1 ----------------------------------
q1	18732	6263	6067	6067
q2	2919	182	169	169
q3	11594	1162	1181	1162
q4	10652	798	854	798
q5	8463	3212	3184	3184
q6	202	128	126	126
q7	867	497	490	490
q8	9250	1997	2003	1997
q9	7306	6423	6389	6389
q10	8251	3075	3085	3075
q11	414	219	211	211
q12	360	198	202	198
q13	18113	3493	3401	3401
q14	245	221	220	220
q15	555	520	512	512
q16	443	375	386	375
q17	953	530	548	530
q18	7772	6984	6867	6867
q19	1612	1331	1376	1331
q20	556	326	325	325
q21	2834	2502	2502	2502
q22	383	336	313	313
Total cold run time: 112476 ms
Total hot run time: 40242 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5768	5816	5719	5719
q2	343	228	219	219
q3	3392	3218	3096	3096
q4	2226	2052	2067	2052
q5	6020	5984	5954	5954
q6	217	127	120	120
q7	2383	1940	1971	1940
q8	3576	3719	3708	3708
q9	9854	25227	9486	9486
q10	5451	3752	3871	3752
q11	592	452	448	448
q12	1148	638	647	638
q13	17159	3302	3264	3264
q14	346	259	272	259
q15	590	511	504	504
q16	536	484	488	484
q17	7704	2031	1995	1995
q18	9674	9192	13502	9192
q19	13698	1600	1595	1595
q20	3850	1958	1923	1923
q21	14668	5614	5688	5614
q22	936	614	627	614
Total cold run time: 110131 ms
Total hot run time: 62576 ms

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.67% (8646/23580)
Line Coverage: 28.69% (70452/245579)
Region Coverage: 27.61% (36410/131888)
Branch Coverage: 24.34% (18632/76560)
Coverage Report: http://coverage.selectdb-in.cc/coverage/86b787e0b36b737cf917e0cf01b00269bd70848e_86b787e0b36b737cf917e0cf01b00269bd70848e/report/index.html

@doris-robot
Copy link

TPC-DS: Total hot run time: 179446 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 86b787e0b36b737cf917e0cf01b00269bd70848e, data reload: false

query1	931	334	326	326
query2	6727	1972	2023	1972
query3	6726	218	204	204
query4	33988	22068	22138	22068
query5	6951	549	566	549
query6	266	181	177	177
query7	4634	281	278	278
query8	229	201	193	193
query9	9179	2740	2731	2731
query10	543	228	240	228
query11	16367	15378	15410	15378
query12	127	71	69	69
query13	1701	384	380	380
query14	11192	7453	7414	7414
query15	215	192	184	184
query16	4646	249	246	246
query17	1019	507	485	485
query18	1806	277	274	274
query19	193	144	148	144
query20	83	80	69	69
query21	192	137	134	134
query22	4912	4790	4559	4559
query23	31886	31152	31086	31086
query24	12644	2805	2861	2805
query25	579	345	328	328
query26	1850	154	159	154
query27	3252	273	282	273
query28	7345	1834	1812	1812
query29	2275	703	695	695
query30	278	139	140	139
query31	986	754	769	754
query32	73	60	60	60
query33	711	251	258	251
query34	1194	477	470	470
query35	889	775	772	772
query36	1404	1260	1301	1260
query37	183	72	71	71
query38	3363	3319	3256	3256
query39	1327	1267	1263	1263
query40	343	98	93	93
query41	40	35	34	34
query42	105	94	96	94
query43	564	545	539	539
query44	1094	688	712	688
query45	211	192	183	183
query46	1062	685	658	658
query47	1737	1641	1612	1612
query48	406	325	324	324
query49	1248	327	303	303
query50	689	323	320	320
query51	5373	5270	5234	5234
query52	95	92	95	92
query53	357	290	299	290
query54	909	460	467	460
query55	99	87	94	87
query56	208	205	197	197
query57	1027	961	959	959
query58	214	197	190	190
query59	3138	2873	2778	2778
query60	231	231	207	207
query61	85	93	85	85
query62	653	402	420	402
query63	322	285	309	285
query64	6275	1745	1738	1738
query65	3379	3252	3253	3252
query66	1432	335	338	335
query67	15783	15341	15424	15341
query68	10142	530	518	518
query69	617	342	337	337
query70	1686	1594	1557	1557
query71	478	249	263	249
query72	4679	2870	2858	2858
query73	2144	321	314	314
query74	7032	6468	6445	6445
query75	4418	2290	2338	2290
query76	5828	1029	992	992
query77	655	281	270	270
query78	9211	8833	8532	8532
query79	1539	510	512	510
query80	603	343	336	336
query81	453	209	207	207
query82	227	92	91	91
query83	148	123	121	121
query84	277	78	72	72
query85	1067	343	332	332
query86	384	415	378	378
query87	3547	3376	3406	3376
query88	3926	2202	2180	2180
query89	459	381	375	375
query90	1986	205	198	198
query91	160	129	125	125
query92	65	55	58	55
query93	3419	419	448	419
query94	1241	195	187	187
query95	533	485	473	473
query96	655	307	309	307
query97	4327	4126	4182	4126
query98	205	199	192	192
query99	1063	745	733	733
Total cold run time: 303119 ms
Total hot run time: 179446 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.21 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 86b787e0b36b737cf917e0cf01b00269bd70848e, data reload: false

query1	0.06	0.05	0.06
query2	0.05	0.03	0.02
query3	0.26	0.13	0.11
query4	1.77	0.13	0.12
query5	0.54	0.53	0.54
query6	1.38	0.64	0.64
query7	0.02	0.02	0.01
query8	0.04	0.02	0.02
query9	0.57	0.50	0.49
query10	0.55	0.57	0.56
query11	0.12	0.09	0.08
query12	0.11	0.10	0.09
query13	0.60	0.60	0.59
query14	0.77	0.80	0.78
query15	0.81	0.79	0.78
query16	0.39	0.40	0.40
query17	0.99	1.00	1.02
query18	0.23	0.27	0.24
query19	1.85	1.80	1.75
query20	0.01	0.01	0.01
query21	15.42	0.60	0.58
query22	2.80	2.46	2.14
query23	17.35	0.87	0.87
query24	2.33	1.34	0.58
query25	0.34	0.23	0.22
query26	0.40	0.14	0.14
query27	0.06	0.06	0.05
query28	11.76	0.84	0.79
query29	12.60	3.31	3.30
query30	0.59	0.49	0.51
query31	2.77	0.34	0.34
query32	3.39	0.50	0.48
query33	3.24	3.19	3.23
query34	15.88	4.20	4.32
query35	4.23	4.24	4.23
query36	1.11	1.07	1.08
query37	0.06	0.04	0.05
query38	0.04	0.03	0.03
query39	0.02	0.02	0.02
query40	0.16	0.13	0.14
query41	0.07	0.02	0.01
query42	0.03	0.02	0.02
query43	0.02	0.02	0.02
Total cold run time: 105.79 s
Total hot run time: 31.21 s

@doris-robot
Copy link

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit 86b787e0b36b737cf917e0cf01b00269bd70848e with default session variables
Stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc:          59 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select:       14.2 seconds inserted 10000000 Rows, about 704K ops/s

@liaoxin01
Copy link
Contributor Author

run p0

zhannngchen
zhannngchen approved these changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@zhannngchen zhannngchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

dataroaring
dataroaring approved these changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit b6aa60c into apache:master Jan 16, 2024
28 of 31 checks passed
yiguolei pushed a commit that referenced this pull request Jan 16, 2024
@liaoxin01 @Doris-Extras
[fix](regression) spare .testfile to make disk checker happy when inj…
08db92a 
…ecting fault (#30012)
hello-stephen pushed a commit to hello-stephen/doris that referenced this pull request Jan 19, 2024
@liaoxin01
[fix](regression) spare .testfile to make disk checker happy when inj…
050ca8b 
…ecting fault (apache#30012)
@liaoxin01 liaoxin01 deleted the fix_inject_fault branch February 6, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhannngchen zhannngchen zhannngchen approved these changes

@dataroaring dataroaring dataroaring approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.5 dev/2.1.0 dev/3.0.0-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@liaoxin01 @doris-robot @zhannngchen @dataroaring @xiaokang