Skip to content

Commit

Permalink
[improvement](statistics)Change auto analyze max width to 300 and hea…
Browse files Browse the repository at this point in the history
…lth threshold to 90. (#42104) (#44379)

backport: #42104
  • Loading branch information
Jibing-Li authored Nov 21, 2024
1 parent 936417e commit eb975f7
Show file tree
Hide file tree
Showing 4 changed files with 22 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,8 @@ public final class GlobalVariable {

public static final int VARIABLE_VERSION_0 = 0;
public static final int VARIABLE_VERSION_100 = 100;
public static final int CURRENT_VARIABLE_VERSION = VARIABLE_VERSION_100;
public static final int VARIABLE_VERSION_101 = 101;
public static final int CURRENT_VARIABLE_VERSION = VARIABLE_VERSION_101;
public static final String VARIABLE_VERSION = "variable_version";

public static final String VERSION_COMMENT = "version_comment";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1776,7 +1776,7 @@ public void setEnableLeftZigZag(boolean enableLeftZigZag) {
"Maximum table width to enable auto analyze, "
+ "table with more columns than this value will not be auto analyzed."},
flag = VariableMgr.GLOBAL)
public int autoAnalyzeTableWidthThreshold = 100;
public int autoAnalyzeTableWidthThreshold = 300;

@VariableMgr.VarAttr(name = AUTO_ANALYZE_START_TIME, needForward = true, checker = "checkAnalyzeTimeFormat",
description = {"该参数定义自动ANALYZE例程的开始时间",
Expand Down Expand Up @@ -1841,7 +1841,7 @@ public void setEnableLeftZigZag(boolean enableLeftZigZag) {
+ "exceeds (100 - table_stats_health_threshold)% since the last "
+ "statistics collection operation, the statistics for this table are"
+ "considered outdated."})
public int tableStatsHealthThreshold = 60;
public int tableStatsHealthThreshold = 90;

@VariableMgr.VarAttr(name = ENABLE_MATERIALIZED_VIEW_REWRITE, needForward = true,
description = {"是否开启基于结构信息的物化视图透明改写",
Expand Down
16 changes: 16 additions & 0 deletions fe/fe-core/src/main/java/org/apache/doris/qe/VariableMgr.java
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@
import org.apache.doris.common.util.SerializationUtils;
import org.apache.doris.nereids.trees.expressions.literal.Literal;
import org.apache.doris.persist.GlobalVarPersistInfo;
import org.apache.doris.statistics.StatisticConstants;
import org.apache.doris.statistics.util.StatisticsUtil;

import com.google.common.base.Preconditions;
import com.google.common.base.Strings;
Expand Down Expand Up @@ -980,6 +982,20 @@ public static void forceUpdateVariables() {
SessionVariable.ENABLE_PIPELINE_X_ENGINE,
String.valueOf(true));
}
if (currentVariableVersion < GlobalVariable.VARIABLE_VERSION_101) {
if (StatisticsUtil.getAutoAnalyzeTableWidthThreshold()
< StatisticConstants.AUTO_ANALYZE_TABLE_WIDTH_THRESHOLD) {
VariableMgr.refreshDefaultSessionVariables("update variable version",
SessionVariable.AUTO_ANALYZE_TABLE_WIDTH_THRESHOLD,
String.valueOf(StatisticConstants.AUTO_ANALYZE_TABLE_WIDTH_THRESHOLD));
}
if (StatisticsUtil.getTableStatsHealthThreshold()
< StatisticConstants.TABLE_STATS_HEALTH_THRESHOLD) {
VariableMgr.refreshDefaultSessionVariables("update variable version",
SessionVariable.TABLE_STATS_HEALTH_THRESHOLD,
String.valueOf(StatisticConstants.TABLE_STATS_HEALTH_THRESHOLD));
}
}
if (currentVariableVersion < GlobalVariable.CURRENT_VARIABLE_VERSION) {
VariableMgr.refreshDefaultSessionVariables("update variable version",
GlobalVariable.VARIABLE_VERSION,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -89,13 +89,13 @@ public class StatisticConstants {

public static final long EXTERNAL_TABLE_AUTO_ANALYZE_INTERVAL_IN_MILLIS = TimeUnit.HOURS.toMillis(24);

public static final int TABLE_STATS_HEALTH_THRESHOLD = 60;
public static final int TABLE_STATS_HEALTH_THRESHOLD = 90;

public static final int ANALYZE_TIMEOUT_IN_SEC = 43200;

public static final int TASK_QUEUE_CAP = 10;

public static final int AUTO_ANALYZE_TABLE_WIDTH_THRESHOLD = 100;
public static final int AUTO_ANALYZE_TABLE_WIDTH_THRESHOLD = 300;

public static final int MSG_LEN_UPPER_BOUND = 1024;

Expand Down

0 comments on commit eb975f7

Please sign in to comment.