Skip to content

Commit

Permalink
[hotfix](external) Fixed External meta replay check (#47928)
Browse files Browse the repository at this point in the history
Related PR: #47603

Problem Summary:

When checking if a table fetched from meta has a remote name, we should use tmpmap
  • Loading branch information
zy-kkk authored Feb 14, 2025
1 parent 9e0c754 commit db80419
Showing 1 changed file with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -237,8 +237,8 @@ public void replayInitDb(InitDatabaseLog log, ExternalCatalog catalog) {
LOG.info("Synchronized table (create): [Name: {}, ID: {}, Remote Name: {}]",
table.getName(), table.getId(), log.getRemoteTableNames().get(i));
}
// Check whether the remoteName and db Tbl db in idToTbl is empty
for (T table : idToTbl.values()) {
// Check whether the remoteName and db Tbl db in tmpIdToTbl is empty
for (T table : tmpIdToTbl.values()) {
if (Strings.isNullOrEmpty(table.getRemoteName())
|| table.getDb() == null) {
LOG.info("Table [{}] remoteName or database is empty, mark as uninitialized",
Expand Down Expand Up @@ -664,8 +664,8 @@ public void gsonPostProcess() throws IOException {
((ExternalTable) obj).getName());
}
}
// Check whether the remoteName and db Tbl db in idToTbl is empty
for (T table : idToTbl.values()) {
// Check whether the remoteName and db Tbl db in tmpIdToTbl is empty
for (T table : tmpIdToTbl.values()) {
if (Strings.isNullOrEmpty(table.getRemoteName())
|| table.getDb() == null) {
initialized = false;
Expand Down

0 comments on commit db80419

Please sign in to comment.