-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: speed up win64 test #8728
Merged
Merged
ci: speed up win64 test #8728
Changes from all commits
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
4748977
Change back to rust 1.74.1 for testing
Jefffrey 18908d5
Run only tpcds planning for faster feedback
Jefffrey c70faae
test
Jefffrey 2b006c5
test
Jefffrey a358c5a
test
Jefffrey f17e064
test
Jefffrey efe74c6
test
Jefffrey 9efc1d5
test
Jefffrey 5931a34
test
Jefffrey 3da2aa5
test
Jefffrey 48d62a1
test
Jefffrey b213b55
test
Jefffrey b8b445a
test
Jefffrey ef96467
test
Jefffrey 632081e
test
Jefffrey bfb94bc
test
Jefffrey 8926c54
test
Jefffrey c85e67c
test
Jefffrey 2e99e21
bad
Jefffrey f67bfce
isolate test
Jefffrey b7438f0
Merge branch 'main' into test_win_ci
Jefffrey 4ef39d0
isolate test bad
Jefffrey 9ea64d4
isolate test bad narrow to physical q44
Jefffrey b36c204
isolate test good narrow to physical q44
Jefffrey b1f125b
physical q44 bad no backtrace
Jefffrey c55a09c
Trigger
Jefffrey 5e1fcdd
physical q44 good no backtrace
Jefffrey 7ed65d2
physical q44 bad with backtrace with stdout
Jefffrey e29e092
physical q44 1.76.0 with backtrace
Jefffrey f6d493e
physical q44 latest nightly with backtrace
Jefffrey 0c7a6f8
physical q44 bad with backtrace with stdout
Jefffrey ccf3949
Merge branch 'main' into test_win_ci
Jefffrey 951063b
try with debuginfo=line-tables-only
Jefffrey b93d7fc
Reenable other checks
Jefffrey e196b5b
Revert win CI check to running all tests
Jefffrey c928ed6
Disable coverage CI
Jefffrey a50b089
Change only debuginfo
Jefffrey 1ddcd05
Commens
Jefffrey 3770594
win remove other rustflag optimizations
Jefffrey 9afd349
Fix comments
Jefffrey d24f851
Trigger
Jefffrey File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -310,11 +310,10 @@ jobs: | |
cd datafusion-cli | ||
cargo test --lib --tests --bins --all-features | ||
env: | ||
# do not produce debug symbols to keep memory usage down | ||
# use higher optimization level to overcome Windows rust slowness for tpc-ds | ||
# and speed builds: https://github.com/apache/arrow-datafusion/issues/8696 | ||
# Cargo profile docs https://doc.rust-lang.org/cargo/reference/profiles.html?profile-settings#profile-settings | ||
RUSTFLAGS: "-C debuginfo=0 -C opt-level=1 -C target-feature=+crt-static -C incremental=false -C codegen-units=256" | ||
# Minimize producing debug symbols to keep memory usage down | ||
# Set debuginfo=line-tables-only as debuginfo=0 causes immensely slow build | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 thank you |
||
# See for more details: https://github.com/rust-lang/rust/issues/119560 | ||
RUSTFLAGS: "-C debuginfo=line-tables-only" | ||
RUST_BACKTRACE: "1" | ||
# avoid rust stack overflows on tpc-ds tests | ||
RUST_MINSTACK: "3000000" | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing the other optimization flags as it caused compilation to take 27 min
Without them, it takes 8 min