chore: remove partition_keys from (Bounded)WindowAggExec #14526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
physical-expr
|
Thank you @irenjj. I'd like to take this ASAP. Can you ping me when it is ready. |
Some tests are failing. I'll let you know when they're fixed. @berkaysynnada |
irenjj
force-pushed
the
remove_partition_keys
branch
from
09039a4 to
d0a8fb5
Compare
|
Hi, @berkaysynnada , all tests have passed, PTAL. |
berkaysynnada
approved these changes
Feb 8, 2025
There was a problem hiding this comment.
LGTM @irenjj, thank you. I've sent a minor commit for further improvements. Do they make sense to you?
Sure, thank you! @berkaysynnada |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?