Use take_function_args in more places

[lgingerich]

Which issue does this PR close?

• Closes Apply take_function_args to functions validating argument count #14516.

What changes are included in this PR?

Refactor manual function argument count validation to use the take_function_args function.

Are these changes tested?

All changes are covered by existing tests.

Are there any user-facing changes?

No.

[lgingerich]

@findepi Is there a good way to use take_function_args() outside of the functions crate?

[alamb]

@findepi Is there a good way to use take_function_args() outside of the functions crate?

I think you would have to move it somwehere like datafusion_common

[lgingerich]

I think you would have to move it somwehere like datafusion_common

Sounds good, I should get to that this weekend and then I'll apply take_function_args() in other crates.

[alamb]

this is so much nicer

[alamb]

FYI @findepi

[alamb]

Thank you so much @lgingerich

I started the CI checks

FYI When I ran some of the tests locally I saw some failures which seem to be related:

 cargo test --test sqllogictests
...
     Running bin/sqllogictests.rs (target/debug/deps/sqllogictests-be41d049b57e846a)
Completed 107 test files in 7 seconds                                                                                       External error: query is expected to fail with error:
	(regex) DataFusion error: Execution error: map requires exactly 2 arguments, got 1 instead
but got error:
	DataFusion error: Execution error: map function requires 2 arguments, got 1
[SQL] SELECT MAP(['POST', 'HEAD'])
at test_files/map.slt:191

Error: Execution("1 failures")
error: test failed, to rerun pass `-p datafusion-sqllogictest --test sqllogictests`

[lgingerich]

@alamb Should be fixed now. I just didn't have the language of the test properly matching this new function.

[lgingerich]

I'll check out these new errors later today.

Is there a simple way to run all these tests locally without manually running each of the difference cargo test combinations? (I'm on MacOS)

[alamb]

I'll check out these new errors later today.

Is there a simple way to run all these tests locally without manually running each of the difference cargo test combinations? (I'm on MacOS)

not sure -- there may be some scripts here https://github.com/apache/datafusion/tree/main/ci/scripts

It would be great to help make it easier to test locally

[alamb]

Thank you @lgingerich -- this looks great to me

[alamb]

I took the liberty of merging this PR up from main to resolve some conflicts: