Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add array_max function support #14470

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion datafusion/functions-aggregate/src/min_max.rs
Original file line number Diff line number Diff line change
Expand Up @@ -574,7 +574,7 @@ fn min_batch(values: &ArrayRef) -> Result<ScalarValue> {
}

/// dynamically-typed max(array) -> ScalarValue
fn max_batch(values: &ArrayRef) -> Result<ScalarValue> {
pub fn max_batch(values: &ArrayRef) -> Result<ScalarValue> {
Ok(match values.data_type() {
DataType::Utf8 => {
typed_min_max_batch_string!(values, StringArray, Utf8, max_string)
Expand Down
2 changes: 2 additions & 0 deletions datafusion/functions-nested/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ pub mod map;
pub mod map_extract;
pub mod map_keys;
pub mod map_values;
pub mod max;
pub mod planner;
pub mod position;
pub mod range;
Expand Down Expand Up @@ -139,6 +140,7 @@ pub fn all_default_nested_functions() -> Vec<Arc<ScalarUDF>> {
length::array_length_udf(),
distance::array_distance_udf(),
flatten::flatten_udf(),
max::array_max_udf(),
sort::array_sort_udf(),
repeat::array_repeat_udf(),
resize::array_resize_udf(),
Expand Down
137 changes: 137 additions & 0 deletions datafusion/functions-nested/src/max.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,137 @@
// Licensed to the Apache Software Foundation (ASF) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing,
// software distributed under the License is distributed on an
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
// KIND, either express or implied. See the License for the
// specific language governing permissions and limitations
// under the License.

//! [`ScalarUDFImpl`] definitions for array_max function.
use crate::utils::make_scalar_function;
use arrow::array::ArrayRef;
use arrow_schema::DataType;
use arrow_schema::DataType::{FixedSizeList, LargeList, List};
use datafusion_common::cast::as_list_array;
use datafusion_common::exec_err;
use datafusion_doc::Documentation;
use datafusion_expr::{ColumnarValue, ScalarUDFImpl, Signature, Volatility};
use datafusion_functions::utils::take_function_args;
use datafusion_functions_aggregate::min_max;
use datafusion_macros::user_doc;
use std::any::Any;

make_udf_expr_and_func!(
ArrayMax,
array_max,
array,
"returns the maximum value in the array.",
array_max_udf
);

#[user_doc(
doc_section(label = "Array Functions"),
description = "Returns the maximum value in the array.",
syntax_example = "array_max(array)",
sql_example = r#"```sql
> select array_max([3,1,4,2]);
+-----------------------------------------+
| array_max(List([3,1,4,2])) |
+-----------------------------------------+
| 4 |
+-----------------------------------------+
```"#,
argument(
name = "array",
description = "Array expression. Can be a constant, column, or function, and any combination of array operators."
)
)]
#[derive(Debug)]
pub struct ArrayMax {
signature: Signature,
aliases: Vec<String>,
}

impl Default for ArrayMax {
fn default() -> Self {
Self::new()
}
}

impl ArrayMax {
pub fn new() -> Self {
Self {
signature: Signature::array(Volatility::Immutable),
aliases: vec!["list_max".to_string()],
findepi marked this conversation as resolved.
Show resolved Hide resolved
}
}
}

impl ScalarUDFImpl for ArrayMax {
fn as_any(&self) -> &dyn Any {
self
}

fn name(&self) -> &str {
"array_max"
}

fn signature(&self) -> &Signature {
&self.signature
}

fn return_type(&self, arg_types: &[DataType]) -> datafusion_common::Result<DataType> {
match &arg_types[0] {
List(field) | LargeList(field) | FixedSizeList(field, _) => {
Ok(field.data_type().clone())
}
_ => exec_err!(
"Not reachable, data_type should be List, LargeList or FixedSizeList"
),
}
}

fn invoke_batch(
&self,
args: &[ColumnarValue],
_number_rows: usize,
) -> datafusion_common::Result<ColumnarValue> {
make_scalar_function(array_max_inner)(args)
}

fn aliases(&self) -> &[String] {
&self.aliases
}

fn documentation(&self) -> Option<&Documentation> {
self.doc()
}
}

/// array_max SQL function
///
/// There is one argument for array_max as the array.
/// `array_max(array)`
///
/// For example:
/// > array_max(\[1, 3, 2]) -> 3
pub fn array_max_inner(args: &[ArrayRef]) -> datafusion_common::Result<ArrayRef> {
let [arg1] = take_function_args("array_max", args)?;

match arg1.data_type() {
List(_) | LargeList(_) | FixedSizeList(_, _) => {
let input_array = as_list_array(&arg1)?.value(0);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as_list_array works only for List(_)
the LargeList(_) | FixedSizeList(_, _) codepath doesn't work

AFAIR, it's hard to create instance of FixedSizeList in SQL, so it will be difficult to test.
i'd suggest to leave it out from the PR for now.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is .value(0)??

let max_result = min_max::max_batch(&input_array);
max_result?.to_array()
}
_ => exec_err!("array_max does not support type: {:?}", arg1.data_type()),
}
}
73 changes: 73 additions & 0 deletions datafusion/sqllogictest/test_files/array.slt
Original file line number Diff line number Diff line change
Expand Up @@ -1433,6 +1433,79 @@ NULL 23
NULL 43
5 NULL


## array_max
# array_max scalar function #1 (with positive index)
query I
select array_max(make_array(5, 3, 6, 4));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a test where query process couple arrays in single array_max call

SELECT input, array_max(input)
FROM (
  SELECT make_array(d-1, d, d-2)
  FROM (VALUES (0), (10), (20), (30), (NULL)) t(d)
)

----
6

query I
select array_max(make_array(5, 3, 4, NULL, 6, NULL));
----
6

query I
select array_max(make_array(NULL, NULL));
----
NULL

query T
select array_max(make_array('h', 'e', 'o', 'l', 'l'));
----
o

query T
select array_max(make_array('h', 'e', 'l', NULL, 'l', 'o', NULL));
----
o

query B
select array_max(make_array(false, true, false, true));
----
true

query B
select array_max(make_array(false, true, NULL, false, true));
----
true

query D
select array_max(make_array(DATE '1992-09-01', DATE '1993-03-01', DATE '1999-05-01', DATE '1985-11-01'));
----
1999-05-01

query D
select array_max(make_array(DATE '1995-09-01', DATE '1999-05-01', DATE '1993-03-01', NULL));
----
1999-05-01

query P
select array_max(make_array(TIMESTAMP '1992-09-01', TIMESTAMP '1995-06-01', TIMESTAMP '1984-10-01'));
----
1995-06-01T00:00:00

query P
select array_max(make_array(NULL, TIMESTAMP '1996-10-01', TIMESTAMP '1995-06-01'));
----
1996-10-01T00:00:00

query R
select array_max(make_array(5.1, -3.2, 6.3, 4.9));
----
6.3

query I
select array_max(make_array());
----
NULL

# Testing with empty arguments should result in an error
query error DataFusion error: Error during planning: 'array_max' does not support zero arguments
select array_max();


## array_pop_back (aliases: `list_pop_back`)

# array_pop_back scalar function with null
Expand Down
33 changes: 33 additions & 0 deletions docs/source/user-guide/sql/scalar_functions.md
Original file line number Diff line number Diff line change
Expand Up @@ -2524,6 +2524,7 @@ _Alias of [current_date](#current_date)._
- [array_intersect](#array_intersect)
- [array_join](#array_join)
- [array_length](#array_length)
- [array_max](#array_max)
- [array_ndims](#array_ndims)
- [array_pop_back](#array_pop_back)
- [array_pop_front](#array_pop_front)
Expand Down Expand Up @@ -2569,6 +2570,7 @@ _Alias of [current_date](#current_date)._
- [list_intersect](#list_intersect)
- [list_join](#list_join)
- [list_length](#list_length)
- [list_max](#list_max)
- [list_ndims](#list_ndims)
- [list_pop_back](#list_pop_back)
- [list_pop_front](#list_pop_front)
Expand Down Expand Up @@ -3002,6 +3004,33 @@ array_length(array, dimension)

- list_length

### `array_max`

Returns the maximum value in the array.

```
array_max(array)
```

#### Arguments

- **array**: Array expression. Can be a constant, column, or function, and any combination of array operators.

#### Example

```sql
> select array_max([3,1,4,2]);
+-----------------------------------------+
| array_max(List([3,1,4,2])) |
+-----------------------------------------+
| 4 |
+-----------------------------------------+
```

#### Aliases

- list_max

### `array_ndims`

Returns the number of dimensions of the array.
Expand Down Expand Up @@ -3759,6 +3788,10 @@ _Alias of [array_to_string](#array_to_string)._

_Alias of [array_length](#array_length)._

### `list_max`

_Alias of [array_max](#array_max)._

### `list_ndims`

_Alias of [array_ndims](#array_ndims)._
Expand Down