Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: include the number of files run in sqllogictest display #14359

Merged
merged 3 commits into from
Jan 30, 2025

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Jan 29, 2025

Which issue does this PR close?

Rationale for this change

While testing #14355 from @findepi I found it hard to see how many files were run

What changes are included in this PR?

Before this PR:

andrewlamb@Andrews-MacBook-Pro-2:~/Software/datafusion$ cargo test --test sqllogictests  -- union
    Finished `test` profile [unoptimized + debuginfo] target(s) in 0.16s
     Running bin/sqllogictests.rs (target/debug/deps/sqllogictests-3d953efd822e1e41)
Completed in 0 seconds

After this PR, it reports Completed 2 tests:

andrewlamb@Andrews-MacBook-Pro-2:~/Software/datafusion$ cargo test --test sqllogictests  -- union
    Finished `test` profile [unoptimized + debuginfo] target(s) in 0.16s
     Running bin/sqllogictests.rs (target/debug/deps/sqllogictests-3d953efd822e1e41)
Completed 2 tests in 0 seconds

Are these changes tested?

I tested them manually

Are there any user-facing changes?

@github-actions github-actions bot added the sqllogictest SQL Logic Tests (.slt) label Jan 29, 2025
fn read_test_files<'a>(
options: &'a Options,
) -> Result<Box<dyn Iterator<Item = TestFile> + 'a>> {
fn read_test_files(options: &Options) -> Result<Vec<TestFile>> {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function was already basically returning a Vec so there didn't seem to be any need to have the iterator indirection

datafusion/sqllogictest/bin/sqllogictests.rs Outdated Show resolved Hide resolved
@alamb alamb merged commit 0edc3d9 into apache:main Jan 30, 2025
25 checks passed
@alamb
Copy link
Contributor Author

alamb commented Jan 30, 2025

Thanks again @findepi

@alamb alamb deleted the alamb/sqllogictest_display branch January 30, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants