Update array_and_element behavior

apache · Feb 13, 2025 · 81e3b52 · 81e3b52
1 parent 9e3754e
commit 81e3b52
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 40 deletions.
diff --git a/datafusion/expr-common/src/signature.rs b/datafusion/expr-common/src/signature.rs
@@ -591,7 +591,7 @@ impl Signature {
                         ArrayFunctionArgument::Array,
                         ArrayFunctionArgument::Element,
                     ],
-                    array_coercion: None,
+                    array_coercion: Some(ListCoercion::FixedSizedListToList),
                 },
             ),
             volatility,

diff --git a/datafusion/functions-nested/src/concat.rs b/datafusion/functions-nested/src/concat.rs
@@ -82,18 +82,7 @@ impl Default for ArrayAppend {
 impl ArrayAppend {
     pub fn new() -> Self {
         Self {
-            signature: Signature {
-                type_signature: TypeSignature::ArraySignature(
-                    ArrayFunctionSignature::Array {
-                        arguments: vec![
-                            ArrayFunctionArgument::Array,
-                            ArrayFunctionArgument::Element,
-                        ],
-                        array_coercion: Some(ListCoercion::FixedSizedListToList),
-                    },
-                ),
-                volatility: Volatility::Immutable,
-            },
+            signature: Signature::array_and_element(Volatility::Immutable),
             aliases: vec![
                 String::from("list_append"),
                 String::from("array_push_back"),

diff --git a/datafusion/functions-nested/src/remove.rs b/datafusion/functions-nested/src/remove.rs
@@ -26,11 +26,9 @@ use arrow::array::{
 use arrow::buffer::OffsetBuffer;
 use arrow::datatypes::{DataType, Field};
 use datafusion_common::cast::as_int64_array;
-use datafusion_common::utils::ListCoercion;
 use datafusion_common::{exec_err, utils::take_function_args, Result};
 use datafusion_expr::{
-    ArrayFunctionArgument, ArrayFunctionSignature, ColumnarValue, Documentation,
-    ScalarUDFImpl, Signature, TypeSignature, Volatility,
+    ColumnarValue, Documentation, ScalarUDFImpl, Signature, Volatility,
 };
 use datafusion_macros::user_doc;
 use std::any::Any;
@@ -80,18 +78,7 @@ impl Default for ArrayRemove {
 impl ArrayRemove {
     pub fn new() -> Self {
         Self {
-            signature: Signature {
-                type_signature: TypeSignature::ArraySignature(
-                    ArrayFunctionSignature::Array {
-                        arguments: vec![
-                            ArrayFunctionArgument::Array,
-                            ArrayFunctionArgument::Element,
-                        ],
-                        array_coercion: Some(ListCoercion::FixedSizedListToList),
-                    },
-                ),
-                volatility: Volatility::Immutable,
-            },
+            signature: Signature::array_and_element(Volatility::Immutable),
             aliases: vec!["list_remove".to_string()],
         }
     }
@@ -248,18 +235,7 @@ pub(super) struct ArrayRemoveAll {
 impl ArrayRemoveAll {
     pub fn new() -> Self {
         Self {
-            signature: Signature {
-                type_signature: TypeSignature::ArraySignature(
-                    ArrayFunctionSignature::Array {
-                        arguments: vec![
-                            ArrayFunctionArgument::Array,
-                            ArrayFunctionArgument::Element,
-                        ],
-                        array_coercion: Some(ListCoercion::FixedSizedListToList),
-                    },
-                ),
-                volatility: Volatility::Immutable,
-            },
+            signature: Signature::array_and_element(Volatility::Immutable),
             aliases: vec!["list_remove_all".to_string()],
         }
     }