feat(browser): Use FadeSplashScreenDuration from config.xml on browser platform #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IgneButene
approved these changes
May 2, 2019
janpio
reviewed
May 2, 2019
src/browser/SplashScreenProxy.js
Outdated
| innerLocalSplash.style["-webkit-transition"] = | ||
| innerLocalSplash.style["-moz-transition"] = | ||
| innerLocalSplash.style["-ms-transition"] = | ||
| innerLocalSplash.style["-o-transition"] = transitionCssString; |
There was a problem hiding this comment.
Uh, does this work this way with foo = bar = baz = value;?
There was a problem hiding this comment.
The other thing I'd like to discuss: Do we even need the prefixes besides for the IE? Looking at caniuse (https://caniuse.com/#feat=css-transitions) the only browser which does not support it unprefixed is the IE <10
There was a problem hiding this comment.
I guess prefixes could be left out .. just didn't want to mess too much with the code.
janpio
approved these changes
May 2, 2019
janpio
changed the title
added 3 commits
November 21, 2022 09:05
# Conflicts: # src/browser/SplashScreenProxy.js
|
Updated this PR so it can be merged after being left for ~2.5yrs 🙈 |
royalrex
requested review from
timbru31 and
janpio
and removed request for
timbru31
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
Browser
What does this PR do?
Use FadeSplashScreenDuration from config.xml on browser platform
What testing has been done on this change?
Manually added the plugin code to production app and published. No errors discovered.
Checklist