CASSSIDECAR-220: Add CdcRawDirectorySpaceCleaner for tracking and cleaning up the cdc_… #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jberragan
changed the title
bbotella
reviewed
Mar 4, 2025
| boolean enableCdcRawDirectoryRoutineCleanUp(); | ||
|
|
||
| /** | ||
| * @return fallback value for maximum directory size in bytes for the `cdc_raw` directory when can't be read from `system_views.settings` table |
| String cdcTotalSpaceInMb = getSetting(YAML_PROP_PREVIOUS); | ||
| if (cdcTotalSpaceInMb != null) | ||
| { | ||
| return FileUtils.mbStringToBytes(cdcTotalSpaceInMb); |
There was a problem hiding this comment.
What do we mean by previous? Is this being deprecated? Maybe we should throw a deprecation warn if that's the case?
There was a problem hiding this comment.
cdc_total_space_in_mb was removed in Cassandra and replaced with cdc_total_space in v5.0+
| periodicTaskExecutor.schedule(healthCheckPeriodicTask); | ||
| periodicTaskExecutor.schedule(cdcRawDirectorySpaceCleaner); | ||
| vertx.eventBus().localConsumer(ON_SERVER_STOP.address(), message -> |
There was a problem hiding this comment.
Please also unschedule the new cdcRawDirectorySpaceCleaner periodic task
| /** | ||
| * @return the critical time period in seconds that indicates the `cdc_raw` directory is not large enough to buffer this time-window of mutations. | ||
| */ | ||
| Duration cdcRawDirectoryCriticalBufferWindow(); |
There was a problem hiding this comment.
Why using Duration instead of SecondBoundConfiguration? Same for cdcRawDirectoryLowBufferWindow and cacheMaxUsage
Comment on lines
163
to
167
| if (!cdcConfiguration.enableCdcRawDirectoryRoutineCleanUp()) | ||
| { | ||
| LOGGER.debug("Skipping CdcRawDirectorySpaceCleaner: feature is disabled "); | ||
| return; | ||
| } |
There was a problem hiding this comment.
Instead of having this check here, why not just prevent the task from being scheduled by overriding scheduleDecision method? Something like:
@Override
public ScheduleDecision scheduleDecision()
{
return cdcConfiguration.enableCdcRawDirectoryRoutineCleanUp() ? ScheduleDecision.EXECUTE : ScheduleDecision.SKIP;
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…raw directories