CASSJAVA-85: decode custom payload and warnings in correct order #2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adutra
approved these changes
Feb 28, 2025
tolbertam
approved these changes
Feb 28, 2025
There was a problem hiding this comment.
Works great, tested against 4.1.8 and could reproduce the issue by adding a test to CustomPayloadTest that writes a large batch producing warnings.
I'll contribute the test in a separate PR as I noticed that the test infra currently doesn't work with newer versions due to yaml changes so will try to sort that out separately.
patch by Tommy Stendahl; reviewed by Alexandre Dutra and Andy Tolbert for CASSJAVA-85
tommystendahl
force-pushed
the
CASSJAVA-85
branch
from
39a7973 to
e8a2531
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
patch by Tommy Stendahl; reviewed by Alexandre Dutra and Andy Tolbert for CASSJAVA-85