CASSJAVA-67 Fixes to get "mvn release:prepare" back on track #2001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absurdfarce
commented
Jan 2, 2025
| <phase>none</phase> | ||
| </execution> | ||
| </executions> | ||
| </plugin> |
There was a problem hiding this comment.
Note: this change actually fixes the "basedir... does not exist" issues originally described in the ticket.
absurdfarce
commented
Jan 2, 2025
| <configuration> | ||
| <skip>false</skip> | ||
| </configuration> | ||
| </plugin> |
There was a problem hiding this comment.
Note: this change (and the change above) are necessary to fix a follow-on issue observed after the "basedir... does not exist" issue was resolved by the change below:
[INFO] [INFO] --- javadoc:3.0.1:jar (attach-javadocs) @ cassandra-driver-dist ---
[INFO] [INFO]
[INFO] [INFO] --- gpg:1.5:sign (sign-release-artifacts) @ cassandra-driver-dist ---
[INFO] [INFO] ------------------------------------------------------------------------
[INFO] [INFO] Reactor Summary for Java Driver for Apache Cassandra 3.11.6-SNAPSHOT:
[INFO] [INFO]
[INFO] [INFO] Java Driver for Apache Cassandra ................... SUCCESS [ 2.041 s]
[INFO] [INFO] Java Driver for Apache Cassandra - Core ............ SUCCESS [ 18.895 s]
[INFO] [INFO] Java Driver for Apache Cassandra - Object Mapping .. SUCCESS [ 9.554 s]
[INFO] [INFO] Java Driver for Apache Cassandra - Extras .......... SUCCESS [ 6.934 s]
[INFO] [INFO] Java Driver for Apache Cassandra - Examples ........ SUCCESS [ 3.299 s]
[INFO] [INFO] Java Driver for Apache Cassandra Tests ............. SUCCESS [ 0.419 s]
[INFO] [INFO] Java Driver for Apache Cassandra Tests - Stress .... SUCCESS [ 1.742 s]
[INFO] [INFO] Java Driver for Apache Cassandra Tests - OSGi ...... SUCCESS [ 0.081 s]
[INFO] [INFO] Java Driver for Apache Cassandra Tests - OSGi - Shaded SUCCESS [ 1.009 s]
[INFO] [INFO] Java Driver for Apache Cassandra Tests - OSGi - Shaded SUCCESS [ 1.175 s]
[INFO] [INFO] Java Driver for Apache Cassandra Tests - OSGi - Unshaded SUCCESS [ 1.068 s]
[INFO] [INFO] Java Driver for Apache Cassandra Tests - Shading ... SUCCESS [ 0.398 s]
[INFO] [INFO] Java Driver for Apache Cassandra Tests - Shading - Shaded SUCCESS [ 0.655 s]
[INFO] [INFO] Java Driver for Apache Cassandra Tests - Shading - Unshaded SUCCESS [ 0.652 s]
[INFO] [INFO] Apache Cassandra Java Driver - source distribution . SUCCESS [ 0.911 s]
[INFO] [INFO] Java Driver for Apache Cassandra - Binary distribution FAILURE [ 0.623 s]
[INFO] [INFO] ------------------------------------------------------------------------
[INFO] [INFO] BUILD FAILURE
[INFO] [INFO] ------------------------------------------------------------------------
[INFO] [INFO] Total time: 50.299 s
[INFO] [INFO] Finished at: 2024-12-26T13:41:48+01:00
[INFO] [INFO] ------------------------------------------------------------------------
[INFO] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-gpg-plugin:1.5:sign (sign-release-artifacts) on project cassandra-driver-dist: The project artifact has not been assembled yet. Please do not invoke this goal before the lifecycle phase "package". -> [Help 1]
[INFO] [ERROR]
patch by Alexandre Dutra; reviewed by Bret McGuire for CASSJAVA-67
absurdfarce
force-pushed
the
cassjava67
branch
from
4bb44d1 to
9ef8377
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: all of the fixes here were developed by @adutra (who has apparently forgotten more about Maven than I'll ever know).
Broken into two commits (for now) to clearly decouple the fix for the initial problem as well as the (completely separate) fix for a follow-on problem @adutra discovered during testing.